-
Notifications
You must be signed in to change notification settings - Fork 795
[CI] First build Base and Build images, then Intel Drivers #20657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
13fb1ba to
6ea5c44
Compare
6ea5c44 to
0beb233
Compare
|
example CI failure in nightly job last weekend: https://github.com/intel/llvm/actions/runs/19381290080/job/55460338609#step:3:914
|
0beb233 to
4db44b8
Compare
4db44b8 to
da18a7e
Compare
da18a7e to
adc94be
Compare
adc94be to
1261236
Compare
1261236 to
98e39d5
Compare
98e39d5 to
2f0fce1
Compare
2f0fce1 to
923ac2c
Compare
923ac2c to
4bb9b3a
Compare
4bb9b3a to
e67e207
Compare
|
Finally extra cleanup takes 1m 21s and gives extra 27GB of free space. @intel/dpcpp-devops-reviewers please review. |
| # Then build "Intel Drivers" images that depend on previous images. | ||
| # Note: Building these images on PR means using old "Base" and "Build" images, | ||
| # as the ones above were not yet pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a deal breaker for us? @sarnex , @uditagarwal97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably yes, but if I understand correctly that the problem is hard drive space can't we just move the job from the GitHub hosted runners to a self-hosted one which has enough space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to just moving docker container build jobs to self-hosted runners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aelovikov-intel, what is the deal breaker?
Just to be on the same page, there are 2 issues here. While I tried fixing issue that "intel drivers" are based on old Base/Build images I noticed the issue that "intel drivers" images can't be build (because they are too big/too litle space is available).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to move building dockers to self-hosted runners, pls let me know which label should I used, at best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I tried fixing issue that "intel drivers" are based on old Base/Build images
Are you saying that it's the same limitation when running this workflow in pre-commit (whenever image-related tasks/code are being updated) before/after PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just created the docker-builder label and put it on some random Linux machine, can you try using that? Probably CI will fail because the OS isn't set up right but I'll set it up once I see the errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-builder used.
Are you saying that it's the same limitation when running this workflow in pre-commit (whenever image-related tasks/code are being updated) before/after PR?
I actually only checked the nightly build - we fixed a dependency for benchmarks, but it was still failing on "nigthly" image, which is based on "intel drivers". Once I re-built "intel drivers" and "nightly" it all worked.
Anyway, I believe if we use only a single runner for building dockers the issue may be gone, because we have these dockers cached in the system...?
side note: we'd have to regularly clean/prune old images from that runner (to free up the disk space).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side note: we'd have to regularly clean/prune old images from that runner (to free up the disk space).
I already have to do this lol
Intel Drivers images were hitting 'No space left on device' error on public runners
e67e207 to
653ca4a
Compare
and fix building "Intel Drivers" images, as they currently can't be built because of "No space left on device" error.