Skip to content

[SYCL][Graph] Align spec and implementation for native recording mode#21974

Merged
uditagarwal97 merged 2 commits into
intel:syclfrom
adamfidel:adam/fix-native-recording-spec-divergence
May 27, 2026
Merged

[SYCL][Graph] Align spec and implementation for native recording mode#21974
uditagarwal97 merged 2 commits into
intel:syclfrom
adamfidel:adam/fix-native-recording-spec-divergence

Conversation

@adamfidel

@adamfidel adamfidel commented May 8, 2026

Copy link
Copy Markdown
Member
  • Changed the exception thrown for out-of-order queues + native recording from feature_not_supported to invalid
  • Throw feature_not_supported in finalize() for native recording instead of update()

Closes #21920.

@adamfidel adamfidel requested a review from a team as a code owner May 8, 2026 19:04
@adamfidel adamfidel requested a review from mmichel11 May 8, 2026 19:04
mmichel11
mmichel11 approved these changes May 11, 2026
View reviewed changes

@mmichel11 mmichel11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question about what the return in the spec should be, but it is not a big issue to me.

Comment thread sycl/source/detail/graph/graph_impl.cpp Outdated
@adamfidel

adamfidel commented May 27, 2026

Copy link
Copy Markdown
Member Author

@intel/llvm-gatekeepers Please consider merging.

@uditagarwal97 uditagarwal97 merged commit a1ffe0e into intel:sycl May 27, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmichel11 mmichel11 mmichel11 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SYCL][Graph] Spec diverges from implementation for native recording mode

3 participants

@adamfidel @mmichel11 @uditagarwal97