Repository navigation
Conversation
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sarnex
commented
Oct 13, 2026
| @@ -30,6 +30,7 @@ | |||
| #include "llvm/Support/Error.h" | |||
| #include "llvm/Support/MemoryBuffer.h" | |||
Contributor
Author
There was a problem hiding this comment.
SimpleTable is in llvm/Support but it is not upstream code.
sarnex
commented
Oct 13, 2026
| }) | ||
| .Case(OPT_MERGE, [&](TformCmd *Cmd) -> Error { | ||
| // argument is <column name> | ||
| assert(Args.size() == 1); |
Contributor
Author
There was a problem hiding this comment.
This is an assert because input validation is already done on line 271-276.
sarnex
marked this pull request as ready for review
October 13, 2026 21:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to do some input validation.
CMPLRLLVM-73539