Skip to content

[SYCL][CUDA] Fix the compiler error reported in https://github.com/intel/llvm/issues/8750 #8765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

jinz2014
Copy link
Contributor

Replace the conditional selection of the version of cuDeviceGetUuid with the CUDA_VERSION macro.

@jinz2014 jinz2014 requested a review from a team as a code owner March 24, 2023 11:53
@jinz2014 jinz2014 requested a review from steffenlarsen March 24, 2023 11:53
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jinz2014 jinz2014 temporarily deployed to aws March 24, 2023 12:20 — with GitHub Actions Inactive
@jinz2014
Copy link
Contributor Author

Thanks for fixing this!

Thank you for your comments and suggestions.

@jinz2014 jinz2014 temporarily deployed to aws March 24, 2023 12:56 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor

CUDA and HIP Failed Tests (1):
SYCL :: Basic/kernel_info.cpp
Unrelated. Reported in #8766 and temporarily disabled in intel/llvm-test-suite#1693.

@steffenlarsen steffenlarsen merged commit 4a4702e into intel:sycl Mar 24, 2023
steffenlarsen pushed a commit that referenced this pull request Jul 5, 2023
This patch re-introduces the fix from
#8765

Which seems to have been accidentally dropped by the UR port.
fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
This patch re-introduces the fix from
intel#8765

Which seems to have been accidentally dropped by the UR port.
fabiomestre pushed a commit to fabiomestre/unified-runtime that referenced this pull request Sep 26, 2023
This patch re-introduces the fix from
intel/llvm#8765

Which seems to have been accidentally dropped by the UR port.
fabiomestre pushed a commit to oneapi-src/unified-runtime that referenced this pull request Sep 27, 2023
This patch re-introduces the fix from
intel/llvm#8765

Which seems to have been accidentally dropped by the UR port.
omarahmed1111 pushed a commit to omarahmed1111/unified-runtime that referenced this pull request Oct 23, 2023
This patch re-introduces the fix from
intel/llvm#8765

Which seems to have been accidentally dropped by the UR port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants