Skip to content

Consider git submodule for gmmlib dependency #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
uartie opened this issue Dec 19, 2017 · 10 comments
Closed

Consider git submodule for gmmlib dependency #35

uartie opened this issue Dec 19, 2017 · 10 comments

Comments

@uartie
Copy link
Contributor

uartie commented Dec 19, 2017

Since commit intel/gmmlib@aa11d6ada523 , the media-driver does not compile (see intel/gmmlib#3) on current media-driver master (4d89071).

If gmmlib was included as a git submodule in media-driver, then the specific commit can be controlled more precisely and prevent recent changes in gmmlib from breaking the media-driver when not warranted. This would also allow media-driver to remove all the cmake scripts that it currently duplicates from gmmlib to simplify maintainability (e.g. keeping them in sync is currently a chore).
@uartie
Copy link
Contributor Author

uartie commented Dec 19, 2017 •
edited
Loading

Curious, is there a reason for separating gmmlib source tree from media-driver source tree (e.g. is it used by other libraries/projects)? Also, since it's separated, why does it not provide standard installation files? The current build setup requirements are awkward and unconventional because of this.

@oliver-sang
Copy link
Contributor

the corresponding media part changes are under testing now. We'll push the changes when tests pass.

Yes, gmmlib is a common component which is now built as a static library then link into different gmmlib 'clients'. There are some tasks for gmmlib changes in the future which should be able to address your concern. Thanks for pointing out these for us now!

@oliver-sang
Copy link
Contributor

fixed at 4bff0eb for build break

@drprajap
Copy link

We have task under progress to transition from static lib to DLL. We should be able to control such issues once transition happens.

Sorry for any inconvenience.
Thanks.

@uartie uartie mentioned this issue Feb 2, 2018
Closed
@chivakker
Copy link
Contributor

gmmlib is ready for this to happen, will it be available soon?

@chivakker chivakker mentioned this issue Jul 23, 2018
Closed
@oliver-sang
Copy link
Contributor

team is working on this.

@dvrogozh
Copy link
Contributor

Folks, I very much don't like an idea to have gmmlib as a submodule assuming that it will be a dynamic library. In that way we will end up having few versions of dynamic gmmlib built within media-driver and compute-runtime procedures. Imho, if gmmlib will be a dynamic library it should be separately installed and packaged. If it will be a static library, then indeed we can have a submodule.

@oliver-sang : can you, please, clarify what team is actually heading for?

@oliver-sang
Copy link
Contributor

Team is working to convert to use dynamic gmmlib. git submodule is not under the consideration.

@dvrogozh
Copy link
Contributor

Cool, that's what I hoped to hear. Do you have an ETA?

dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 8, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
9d3390f 
Fixes: intel#246, intel#35

Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
@dvrogozh dvrogozh mentioned this issue Aug 8, 2018
Merged
dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 10, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
7e64a53 
Fixes: intel#246, intel#35

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 14, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
700ac49 
Fixes: intel#246, intel#35

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 14, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
b28e4a1 
Fixes: intel#246, intel#35
Requires: intel/gmmlib#30

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 15, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
899084a 
Fixes: intel#246, intel#35

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 15, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
ba91775 
Fixes: intel#246, intel#35

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 16, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
1f12f13 
Fixes: intel#246, intel#35

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
@dvrogozh dvrogozh mentioned this issue Aug 17, 2018
Closed
dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 17, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
c63210c 
Fixes: intel#246, intel#35

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh pushed a commit to dvrogozh/media-driver that referenced this issue Aug 24, 2018
@yangning1368 @dvrogozh
switch to dynamic gmmlib
e7ce516 
Fixes: intel#246, intel#35

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
Sherry-Lin pushed a commit that referenced this issue Aug 24, 2018
@yangning1368 @Sherry-Lin
switch to dynamic gmmlib
87fadbe 
Fixes: #246, #35

Change-Id: I6d48c72d86e26a2f8db06891dccb22dc66afa004
Signed-off-by: Yang, Ning <[email protected]>
Signed-off-by: Dmitry Rogozhkin <[email protected]>
@XinfengZhang
Copy link
Contributor

close it , because gmmlib is a .so now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@chivakker @uartie @dvrogozh @oliver-sang @XinfengZhang @drprajap