Revert "[SW-219134] dynamically remove 2x content" #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cfb38fa.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the dynamic removal of content in the installation files that was previously implemented to adjust behavior based on the installed version. Key changes include:
- Removal of functions that alter file content in setup.py.
- Removal of dynamic delete calls in the "pt" and "tf" branches of get_build_version.
- Addition of a clarifying comment in neural_compressor/init.py.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Reverts dynamic manipulation of file content for versioning. |
| neural_compressor/init.py | Adds a comment regarding the need for a global 'NA' backend. |
Files not reviewed (1)
- .azure-pipelines/scripts/ut/3x/collect_log_3x.sh: Language not supported
Comments suppressed due to low confidence (1)
setup.py:112
- The else branch in get_build_version still calls replace_lines_from_file, but its definition has been removed in this PR. Please update or remove this call to ensure that the function is not referenced.
replace_lines_from_file(*content_position, backup_content)
chensuyue
approved these changes
Apr 23, 2025
XuehaoSun
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with @ulivne
This is not a good approach because it can introduce changes to the development environment and cause unintentional commits.