This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Testing commit. #381
Open
Testing commit. #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkulesza1
commented
Oct 27, 2016
•
kkulesza1
commented
-
General Comment
- <img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'> Please explain in te commit message why you are removing those files (i.e. they are not used by anyone anymore).
- <img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'> Please do not remove hostConfig.py: it is used in domainGenerator.py. Also, please squash your changes in a single commit.
|
Please explain in te commit message why you are removing those files (i.e. they are not used by anyone anymore). |
Merge branch 'pull-request-example' of https://github.com/kkulesza1/parameter-framework into pull-request-example
|
Please do not remove hostConfig.py: it is used in domainGenerator.py. Also, please squash your changes in a single commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.