Skip to content
This repository was archived by the owner on Mar 5, 2024. It is now read-only.

cmac_mode: s/const static/static const/ #29

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

haukepetersen
Copy link
Contributor

Just adding tinycrypt as package to RIOT. When building with RIOT's default cflags (-Wextra), gcc throws a warning about

`static' is not at beginning of declaration [-Werror=old-style-declaration]`

Seems at least the c99 standard also prefers the static declaration to come first:

(C99, 6.11.5p1) "The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature"

So a simple word-order swap solves this issue...

As I haven't contributed to this project before, is there anything else to do besides opening this PR?

Copy link
Contributor

@mczraf mczraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Word swap ("static const") in cmac to avoid compilation warning.

@haukepetersen
Copy link
Contributor Author

Hej, any news on this fix?

@mczraf
Copy link
Contributor

mczraf commented Jan 24, 2018

Merged. Thanks for contributing!

@haukepetersen
Copy link
Contributor Author

Thanks for merging :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants