Repository navigation
[3/N] Synchronize test files with upstream generalization changes - #5435
Merged
Merged
Conversation
pbielak
added
disable_e2e
pbielak
force-pushed
the
use-upstream-files-3
branch
from
September 18, 2026 08:34
d7c6e4b to
84c0648
Compare
BBBela
reviewed
Sep 18, 2026
BBBela
left a comment
BBBela
left a comment
Contributor
There was a problem hiding this comment.
It makes sense for me to include those new test files in torch-xpu-ops CI, especially as they are now generalized in upstream and launched in upstream XPU CI.
It looks like necessary step to prevent all the torch-xpu-ops PRs from introducing any regression.
Although they were not ported for XPU so far due to reasons I don't know, so it would be best to have an official confirmation from PRC team that we can proceed with enabling testing all the device-related test files from upstream that are already generic, but have not been tested in torch-xpu-ops CI so far.
To sum up - for me the change looks good, but I will wait with approval until PRC team confirms we can introduce all those new tests into torch-xpu-ops CI.
BBBela
approved these changes
Sep 22, 2026
pbielak
force-pushed
the
use-upstream-files-3
branch
from
September 23, 2026 08:28
84c0648 to
183d957
Compare
pbielak
force-pushed
the
use-upstream-files-3
branch
from
September 24, 2026 08:49
183d957 to
c93d398
Compare
pbielak
added
the
disable_build
Contributor
Author
|
@torchxpubot merge -f "CI failures are unrelated to PR changes" |
Contributor
|
PR has been successfully merged by @pbielak (force merge). |
orrangetabby17
pushed a commit
that referenced
this pull request
Oct 8, 2026
) The recent upstream generalization changes need to be synchronized with torch-xpu-ops. This PR considers files that were not present in torch-xpu-ops - add entries to `skip_list_common.py` to run them: - `test_ao_sparsity.py` (pytorch/pytorch#191202) - `autograd/test_functional.py` (pytorch/pytorch#191342) - `test_functional_autograd_benchmark.py` (pytorch/pytorch#191474) - `test_mkldnn.py` (pytorch/pytorch#191740) - `lazy/test_reuse_ir.py` (pytorch/pytorch#192240) - `test_stateless.py` (pytorch/pytorch#192218) - `test_overrides.py` (pytorch/pytorch#194257) - `functorch/test_compile_to_python.py` (pytorch/pytorch#195457) - `test_opaque_obj_v2.py` (pytorch/pytorch#195854)
minmingzhu
pushed a commit
to minmingzhu/torch-xpu-ops
that referenced
this pull request
Oct 28, 2026
…tel#5435) The recent upstream generalization changes need to be synchronized with torch-xpu-ops. This PR considers files that were not present in torch-xpu-ops - add entries to `skip_list_common.py` to run them: - `test_ao_sparsity.py` (pytorch/pytorch#191202) - `autograd/test_functional.py` (pytorch/pytorch#191342) - `test_functional_autograd_benchmark.py` (pytorch/pytorch#191474) - `test_mkldnn.py` (pytorch/pytorch#191740) - `lazy/test_reuse_ir.py` (pytorch/pytorch#192240) - `test_stateless.py` (pytorch/pytorch#192218) - `test_overrides.py` (pytorch/pytorch#194257) - `functorch/test_compile_to_python.py` (pytorch/pytorch#195457) - `test_opaque_obj_v2.py` (pytorch/pytorch#195854)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent upstream generalization changes need to be synchronized with torch-xpu-ops. This PR considers files that were not present in torch-xpu-ops - add entries to
skip_list_common.pyto run them:test_ao_sparsity.py([3/N][Test] Enabletorch_ao_sparsity.pyfor XPU pytorch/pytorch#191202)autograd/test_functional.py([Test] Generalizeautograd/test_functional.pytests and enable on XPU pytorch/pytorch#191342)test_functional_autograd_benchmark.py([Test] Generalizetest_functional_autograd_benchmark.pypytorch/pytorch#191474)test_mkldnn.py([Test] Generalizetest_mkldnn.pytests and enable on XPU pytorch/pytorch#191740)lazy/test_reuse_ir.py([Test][XPU] Refactor reuse_ir tests to device-type harness and enable XPU pytorch/pytorch#192240)test_stateless.py([Test] Move device-dependent tests in test_stateless.py to a device-generic class pytorch/pytorch#192218)test_overrides.py([Test] Add hw_classification and enable XPU for test_overrides.py pytorch/pytorch#194257)functorch/test_compile_to_python.py([Test] Maketest/functorch/test_compile_to_python.pytests device-generic and enable XPU. pytorch/pytorch#195457)test_opaque_obj_v2.py([Test] Refactortest_opaque_obj_v2.pyand enable tests on XPU pytorch/pytorch#195854)