Repository navigation
Conversation
The upstream PR pytorch/pytorch#203621 removed the deprecated public TorchScript APIs and their tests, which broke collection of two of our wrappers: **dynamo/test_misc_xpu.py** - upstream removed the `TestTracer` class from `test/dynamo/test_misc.py` - the wrapper added nothing over the upstream file (`XPUImportCtx(False)` applies no patches, and upstream already instantiates `MiscTestsDevice` for XPU), so remove it - move its `skip_list_common.py` entry to the upstreamed tests section as `dynamo/test_misc.py` **test_cpp_api_parity_xpu.py** - upstream retired the C++ API parity driver, deleting `test/test_cpp_api_parity.py` and the `test/cpp_api_parity/` helper package the wrapper imports, so remove it - remove its entry from `skip_list_common.py` - remove its entry from the `tools/fixheaders/pytorch.yaml` exclude list Fixes #6142 Fixes #6143
pbielak
added
disable_e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream PR pytorch/pytorch#203621 removed the deprecated public TorchScript APIs and their tests, which broke collection of two of our wrappers:
dynamo/test_misc_xpu.py
TestTracerclass fromtest/dynamo/test_misc.pyXPUImportCtx(False)applies no patches, and upstream already instantiatesMiscTestsDevicefor XPU), so remove itskip_list_common.pyentry to the upstreamed tests section asdynamo/test_misc.pytest_cpp_api_parity_xpu.py
test/test_cpp_api_parity.pyand thetest/cpp_api_parity/helper package the wrapper imports, so remove itskip_list_common.pytools/fixheaders/pytorch.yamlexclude listFixes #6142
Fixes #6143