-
-
Notifications
You must be signed in to change notification settings - Fork 529
Frontend - actions buttons for playbooks and pivots #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some food for thought. View full project report here.
drosetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a bug during the pivots creation: the UI doesn't allow to select the related analyzer config. Also the field path is not stored correctly (from django admin the parameter in the PivotConfig is not filled correctly).
drosetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a 500 if: create a pivot, create a playbook with the pivot, run a job with the playbook, investigation created successfully with two jobs. Try to delete the pivot -> 500.
drosetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a performance issue, plugin -> pivot page seems slow and when I edit an existing pivot (previosly create with the same UI) it seems not responsible and when I press on save button it seems not effective.
…2451) * added EditPlaybookConfig modal * frontend tests * added plugins dropdown menu * create buttons * added pivot actions buttons * adjusted pivot field * fix * prettier * fix test * adjusted useOrganizationStore * adjusted PivotConfigForm * prettier * info icon * fix tests * fix * added note * fix * fixes * fixes * refactor * prettier
…2451) * added EditPlaybookConfig modal * frontend tests * added plugins dropdown menu * create buttons * added pivot actions buttons * adjusted pivot field * fix * prettier * fix test * adjusted useOrganizationStore * adjusted PivotConfigForm * prettier * info icon * fix tests * fix * added note * fix * fixes * fixes * refactor * prettier
Description
Added:
Type of change
Please delete options that are not relevant.
Checklist
developdumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.urlthat contains this information. This is required for Health Checks._monkeypatch()was used in its class to apply the necessary decorators.MockUpResponseof the_monkeypatch()method. This serves us to provide a valid sample for testing.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.DeepSource,Django Doctorsor other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules