-
-
Notifications
You must be signed in to change notification settings - Fork 529
[Analyzer] UltraDNS #1783 #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f2cd1e8 to
5b5bafd
Compare
|
@mlodic, Please review. |
mlodic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review the checklist, some important steps are missing
| except Exception as e: | ||
| raise AnalyzerRunException(f"An error occurred: {e}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed cause the framework already manages it in this way (the upper class)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
...zers_manager/observable_analyzers/dns/dns_malicious_detectors/ultradns_malicious_detector.py
Outdated
Show resolved
Hide resolved
api_app/playbooks_manager/migrations/0057_add_ultradns_to_free_to_use.py
Outdated
Show resolved
Hide resolved
api_app/analyzers_manager/migrations/0143_analyzer_config_ultradns_malicious_detector.py
Show resolved
Hide resolved
5b5bafd to
8172ba2
Compare
|
once the tests pass I'll merge this :) |
|
please fix migration issues |
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
8172ba2 to
af3c0ca
Compare
|
I have solved the migration errors and ran the tests locally. It should be ready to merge now. |
Description
I have added two analyzers for UltraDNS ( ultradns resolver and ultradns malicious detector). I have added the migration files for both of the analysers and have also added the migration files to add them both to the free_to_use playbook.
Type of change
Please delete options that are not relevant.
Checklist
developdumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.urlthat contains this information. This is required for Health Checks._monkeypatch()was used in its class to apply the necessary decorators.MockUpResponseof the_monkeypatch()method. This serves us to provide a valid sample for testing.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.DeepSource,Django Doctorsor other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules