Skip to content

[BREAKING] chore: upgrade to polkadot 0.9.42 #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

sander2
Copy link
Member

@sander2 sander2 commented Jun 29, 2023

See release notes for 0.9.40, 0.9.41+0.9.42

  • can't upgrade to 0.9.43 yet - we are blocked on xcm-emulator.
  • constant weights now produce warnings, which in most pallets we treat as errors. So I added benchmarks for some escrow functions. The dexstable pallet also has a ton of constant weights, but warning are allowed there. These constant weights do pose a risk, so I removed dex-stable calls from the runtime.
  • pallet-balances changed how they treat existential deposits. They now need the free balance to be above the ED, rather than (free + reserved).
  • orml changed Tokens::balance - rather than returning free + reserved, it now returns free.
  • runtime apis now require TypeInfo to be implemented. Includes Metadata V15, although it's still unstable. Looks like it will be stabalized very soon. Edit: it's stablized now. I guess with 0.9.44 it'll be stabalized. Preview of how we can use it in subxt here
  • I had to upgrade compiler versions, I was getting an error on the older version: #[alloc_error_handler] function required, but not found` Newest version was working locally, but failing in CI. I pick a random version from about 3 months ago, and that seems to work in the CI as well

@sander2 sander2 force-pushed the chore/bump-polkadot branch from 0f1aa97 to d04d6d7 Compare June 30, 2023 13:00
Copy link
Member

@gregdhill gregdhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments, but otherwise looks good. Didn't realise we still had any constant weights but it's good that those are caught now. Also excited for the new metadata with runtime-apis, I guess we can remove the custom RPCs after the next upgrade or when there is good support in polkadot-js / subxt.

@sander2 sander2 enabled auto-merge (squash) July 5, 2023 18:47
@sander2 sander2 merged commit ded7d37 into interlay:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants