This repository was archived by the owner on Apr 6, 2020. It is now read-only.
[WIP] implement new VGA as per RFC 0005 #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-implement Vga::new to hide pointer location from the kernel since the pointer location 0xb8000 is already known by the VGA it should be inside the VGA's implementation and not the kernel's - implement Vga::from_raw
|
this fails on travis rn because of this: rust-lang/rust#39083 tested locally on |
|
guh. sorry that i am the worst and let this sit for over a year. I feel terrible. I'm trying to get back to a clean slate here, so sadly, i need to close this. I hope you got something out of this, sorry for failing you :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-implement
Vga::newto hide pointer location from the kernelsince the pointer location 0xb8000 is already known by the VGA
it should be inside the VGA's implementation and not the kernel's
implement
Vga::from_raw