Skip to content

Remove --monkeypatch solrupdater opts #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented May 25, 2019

Description

Refactor: removes the deadcode --monkeypatch option from new-solr-updater and update_work

Closes #2148

Testing

  • Besides letting my IDE do its magic, I also looked through any reference of monkeypatch to make sure it wasn't used in some weird file.
  • new-solr-updater and update_work both continued to run fine locally
  • Luckily Monkeypatch wasn't tested, so there were no test files to fix :P

@cdrini cdrini added the Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] label May 25, 2019
@tfmorris
Copy link
Contributor

LGTM

@mekarpeles mekarpeles merged commit 9f0be26 into internetarchive:master May 31, 2019
@cdrini cdrini deleted the 2148/refactor/remove-solrupdater-monkeypatch branch June 7, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove new-solr-updater --monkeypatch deadcode option
3 participants