Create check-in on reading log add #6987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add minimal UI for POSTing new check-ins - UI only accessible to admins - UI is expected to be temporary. Its purpose is to demonstrate how check-in data is POSTed, and to provide a quick way to add dummy check- ins
- Change `json` endpoint - Change is_valid - Extend persistence class from `CommonExtras`
jimchamp
added
the
State: Blocked
cclauss
reviewed
Oct 2, 2022
| FINISH = 3 | ||
|
|
||
| @classmethod | ||
| def has_key(cls, key: str) -> bool: |
There was a problem hiding this comment.
Will this work? has_key() is kinda passe.
Suggested change
| def has_key(cls, key: str) -> bool: | |
| def __contains__(cls, key: str) -> bool: |
There was a problem hiding this comment.
Thanks for this note! I tried this and was seeing TypeDef errors when checking if an int was in BookshelfEvents. I applied this review note and fixed the error in #7212
cclauss
reviewed
Oct 2, 2022
Comment on lines
+337
to
+338
| today = date.today() | ||
| date_str = f'{today.year}-{today.month:02}-{today.day:02}' |
There was a problem hiding this comment.
Suggested change
| today = date.today() | |
| date_str = f'{today.year}-{today.month:02}-{today.day:02}' | |
| date_str = f"{date.today():%Y-%m-%d}" |
cclauss
reviewed
Oct 2, 2022
Comment on lines
+72
to
+74
| if not BookshelfEvent.has_key(data['event_type']): | ||
| return False | ||
| return True |
There was a problem hiding this comment.
Suggested change
| if not BookshelfEvent.has_key(data['event_type']): | |
| return False | |
| return True | |
| return BookshelfEvent.has_key(data['event_type']) |
bicolino34
removed
the
State: Blocked
This was referenced Nov 5, 2022
|
Closing this as we have decided that patrons should check in manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically creates a check-in event whenever a book is added to "Currently Reading" or "Already Read" reading logs.
Blocked by #6662 --- Once that is merged, this will need to be rebased.
Technical
Testing
Screenshot
Stakeholders