[uss_qualifier] expand OIR implicit sub handling scenario #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Shastick
force-pushed
the
oir-simple-3-replace-none-with-implicit
branch
5 times, most recently
from
873ce18 to
9204ef9
Compare
Shastick
force-pushed
the
oir-simple-3-replace-none-with-implicit
branch
from
9204ef9 to
6f57e0d
Compare
mickmis
approved these changes
May 22, 2025
|
|
||
| ### [Create OIR with no subscription test step](./fragments/oir/crud/create_query.md) | ||
|
|
||
| #### [OIR is not attached to an implicit subscription](./fragments/oir/oir_has_expected_subscription.md) |
There was a problem hiding this comment.
This check is not implemented.
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.md
Outdated
Show resolved
Hide resolved
Shastick
force-pushed
the
oir-simple-3-replace-none-with-implicit
branch
6 times, most recently
from
69009c0 to
d74396d
Compare
|
@mickmis to cleanly add the missing checks I extracted existing logic to a fragment, let me know if you'd prefer a separate PR. Otherwise this should be good to merge. |
Shastick
force-pushed
the
oir-simple-3-replace-none-with-implicit
branch
2 times, most recently
from
282f56d to
3bc929b
Compare
Shastick
force-pushed
the
oir-simple-3-replace-none-with-implicit
branch
from
3bc929b to
bdb6d90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover the case where we attach an existing and valid implicit subscription to an OIR that is currently not attached to any subscription.
This covers scenario (2) from interuss/dss#1088