Skip to content

Modify some router setups in example projects #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Modify some router setups in example projects #418

merged 1 commit into from
Apr 1, 2021
+5 −9

Conversation

PeterAlfredLee
Copy link
Member

Modify navigation guards:

  1. Remove parameter from because it's not used
  2. Remove parameter next， use recommended way by vue router for instead, see also this

@kazupon kazupon added the Type: Example Includes example and demo code fixes label Apr 1, 2021
kazupon
kazupon approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This fix is for example code.
so, I'll merge it! :)

@kazupon kazupon merged commit b1687fe into intlify:master Apr 1, 2021
@PeterAlfredLee PeterAlfredLee deleted the update_example_router branch April 1, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
Type: Example Includes example and demo code fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterAlfredLee @kazupon