After update from `0.3.28` to `0.3.33` got errors

[phuongphally]

After update from 0.3.28 to 0.3.33 got errors has below

graphql.AssertException: All types within a GraphQL schema must have unique names. No two provided types may have the same name.
No provided type may have a name which conflicts with any built in types (including Scalar and Introspection types).
You have redefined the type 'LocalDate' from being a 'GraphQLScalarType' to a 'GraphQLScalarType'

[negesti]

I guess you have a column "LocalDate" somewhere in your entities?

[igdianov]

@phuongphally Do you merge two schemas from different sources? If you use one entity manager it should not be a problem?

[phuongphally]

I setup version 0.3.28 with existing project then it works fine,
But after I change version from 0.3.28 to 0.3.33

Error response

Duplicate type from the entities
graphQLSchemaFactoryBean' threw exception; nested exception is graphql.AssertException: All types within a GraphQL schema must have unique names. No two provided types may have the same name. No provided type may have a name which conflicts with any built in types (including Scalar and Introspection types). You have redefined the type 'CodeValue' from being a 'GraphQLScalarType' to a 'GraphQLObjectType' INFO o.s.o.j.LocalContainerEntityManagerFactoryBean Closing JPA EntityManagerFactory for persistence unit 'core'

you have redefined the type 'EntityName' from being a 'GraphQLScalarType' to a 'GraphQLObjectType'

EntityName are all entity from project

[phuongphally]

@igdianov I use one entity manager. Do you have any ideas to help me?

[negesti]

A wild guess, as the exceptions say "from scalar to object".
Have you defined your foreign key relations witch the same name as the entities?

[phuongphally]

@negesti You said right. we define it. But the last version of 0.0.28 works well.

[negesti]

If so, my next guess is that is related to #173 (if the properties are defined UpperCase).

Then the SchemaFactoryBean creates a GraphQLObjectType named "CodeValue" and a "GraphQLScalarType" for the property. Changing the property name to "codeValue" should fix that.

[phuongphally]

@negesti Thanks answer quickly to answer.

1. Your AS "Changing the property name to "codeValue" should fix that. " Sorry this answer I'm not clear. I have CodeValue Class in project

@Entity
@Table(name = "m_code_value", uniqueConstraints = {@UniqueConstraint(columnNames = {"code_id", "code_value"}, name = "code_value_duplicate")})
@Getter
public class CodeValue extends AbstractPersistableCustom {

    @Column(name = "code_value", length = 100)
    private String label;

    @Column(name = "order_position")
    private int position;

    @Column(name = "code_description")
    private String description;

    @ManyToOne
    @JoinColumn(name = "code_id", nullable = false)
    private Code code;

    @Column(name = "is_active")
    private boolean active;

    @Column(name = "is_mandatory")
    private boolean mandatory;

I use in class like

@Entity
@Table(name = "m_group_roles")
@Getter
public class GroupRole extends AbstractPersistableCustom {

    @ManyToOne(fetch = FetchType.LAZY)
    @JoinColumn(name = "role_cv_id")
    private CodeValue role;

I use many place with this class , So what should I do? I have to change it all that has to reference?

[igdianov]

@phuongphally This looks like a regression introduced in later versions. Can you create a PR with a minimal test example of the entity model that causes this error? I will fix it.

[phuongphally]

@igdianov I'm still can not be fixed it.

You have redefined the type 'AppUser' from being a 'GraphQLObjectType' to a 'GraphQLScalarType'

If I change method getGraphQLTypeFromJavaType it work with just Type GraphqlLong

  if (clazz.getSimpleName().equalsIgnoreCase("AppUser") ) {
            return Scalars.GraphQLLong;
 }

private GraphQLOutputType getGraphQLTypeFromJavaType(Class<?> clazz) {
        if (clazz.isEnum()) {

            if (classCache.containsKey(clazz))
               return classCache.get(clazz);
            
            
            GraphQLEnumType.Builder enumBuilder = GraphQLEnumType.newEnum().name(clazz.getSimpleName());
            int ordinal = 0;
            for (Enum<?> enumValue : ((Class<Enum<?>>)clazz).getEnumConstants())
                enumBuilder.value(enumValue.name(), ordinal++);

            GraphQLEnumType enumType = enumBuilder.build();
            setNoOpCoercing(enumType);

            classCache.putIfAbsent(clazz, enumType);
            
            return enumType;
        } else if (clazz.isArray()) {
            return GraphQLList.list(JavaScalars.of(clazz.getComponentType()));
        }
        if (clazz.getSimpleName().equalsIgnoreCase("AppUser") ) {
            return Scalars.GraphQLLong;
        }
        return JavaScalars.of(clazz);
    }

But I can not know how to fix it. Any ideas of that case?

[igdianov]

@phuongphally I suspect the problem is with custom object scalar mapping, but I need an example that fails for test case. Can you post the minimal example with JPA models that cause the error? It will save me time to fix it..

[phuongphally]

@igdianov I'm sorry I can not find the problem with custom objects.

But what I found an issue on the library since upgrade from version 0.3.28 to version 0.3.29

You changed IntrospectionUtils with CachedPropertyDescriptor to .EntityIntrospector.EntityIntrospectionResult.AttributePropertyDescriptor in GraphQLJpaSchemaBuilder and it is not cache maybe.

Can you check this if you have time? Because many changed I can not figure out.

When I try to use IntrospectionUtils everything works again.

Thanks

[phuongphally]

@igdianov It is errors from .fields(getTransientFields(entityType.getJavaType()) if I comment it out it work fine

 private GraphQLObjectType computeObjectType(EntityType<?> entityType) {
    	return GraphQLObjectType.newObject()
				                .name(entityType.getName())
				                .description(getSchemaDescription(entityType.getJavaType()))
				                .fields(getEntityAttributesFields(entityType))
				              //  .fields(getTransientFields(entityType.getJavaType()))
				                .build();
    }

[phuongphally]

@igdianov I found the problem because of method isTransient() no @Transient check

Current is

           public boolean isTransient() {
                return !attribute.isPresent();
            }

Change to

           public boolean isTransient() {
                return !attribute.isPresent() && isAnnotationPresent(Transient.class);
            }

[igdianov]

@phuongphally Thank you for troubleshooting this! I will fix it today.