Skip to content

Support MappedSuperclass for JPA entity attributes #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

miklemv
Copy link
Contributor

@miklemv miklemv commented Apr 21, 2019

Fix mapping for entity class attributes declared in @MappedSuperclass base entity

@miklemv miklemv mentioned this pull request Apr 21, 2019
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #113 into master will decrease coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #113      +/-   ##
============================================
- Coverage     66.35%   65.82%   -0.53%     
+ Complexity      379      370       -9     
============================================
  Files            34       37       +3     
  Lines          2030     2025       -5     
  Branches        302      299       -3     
============================================
- Hits           1347     1333      -14     
- Misses          552      562      +10     
+ Partials        131      130       -1
Impacted Files Coverage Δ Complexity Δ
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 86.66% <100%> (-0.61%) 105 <2> (-8)
...ventures/graphql/jpa/query/schema/JavaScalars.java 32.9% <0%> (-3.42%) 3% <0%> (-1%)
...a/query/schema/impl/QraphQLJpaBaseDataFetcher.java 71.91% <0%> (-0.86%) 113% <0%> (-2%)
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 46.11% <0%> (-0.52%) 41% <0%> (-1%)
...graphql/jpa/query/schema/impl/PredicateFilter.java 96.87% <0%> (-0.1%) 4% <0%> (ø)
.../example/starwars/StarwarsSchemaConfiguration.java 100% <0%> (ø) 4% <0%> (ø) ⬇️
.../query/example/books/BooksSchemaConfiguration.java 100% <0%> (ø) 4% <0%> (ø) ⬇️
...jpa/query/schema/model/starwars/DroidFunction.java
...ures/graphql/jpa/query/schema/model/book/Book.java
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3c919...68f7b72. Read the comment docs.

@igdianov
Copy link
Collaborator

igdianov commented Apr 22, 2019

@miklemv Can you please provide the explanation in the PR description what problem your PR solves?

The @MappedSuperClass is already supported here:

@miklemv
Copy link
Contributor Author

miklemv commented Apr 23, 2019

@igdianov igdianov changed the title Support MappedSuperclass Support MappedSuperclass for JPA entity attributes Apr 24, 2019
@igdianov
Copy link
Collaborator

Merged via #120

@igdianov igdianov closed this Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants