Skip to content

fix: enable default distinct configuration property #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2019

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented May 5, 2019

This PR fixes GraphQLJPAQueryProperites.isDefaultDistinct typo and enables default distinct resolution configuration.

@igdianov igdianov self-assigned this May 5, 2019
@igdianov igdianov added the bug label May 5, 2019
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
+ Coverage     68.39%   68.49%   +0.09%     
- Complexity      405      407       +2     
============================================
  Files            33       33              
  Lines          2079     2079              
  Branches        311      311              
============================================
+ Hits           1422     1424       +2     
+ Misses          531      529       -2     
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...query/autoconfigure/GraphQLJpaQueryProperties.java 90.9% <100%> (+9.09%) 11 <0> (+2) ⬆️
.../query/schema/impl/GraphQLJpaQueryDataFetcher.java 93.68% <100%> (ø) 23 <1> (ø) ⬇️
.../query/example/books/BooksSchemaConfiguration.java 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18a6ce...5cbc291. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
+ Coverage     68.39%   68.49%   +0.09%     
- Complexity      405      407       +2     
============================================
  Files            33       33              
  Lines          2079     2079              
  Branches        311      311              
============================================
+ Hits           1422     1424       +2     
+ Misses          531      529       -2     
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...query/autoconfigure/GraphQLJpaQueryProperties.java 90.9% <100%> (+9.09%) 11 <0> (+2) ⬆️
.../query/schema/impl/GraphQLJpaQueryDataFetcher.java 93.68% <100%> (ø) 23 <1> (ø) ⬇️
.../query/example/books/BooksSchemaConfiguration.java 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18a6ce...5cbc291. Read the comment docs.

@igdianov igdianov merged commit 6359449 into master May 6, 2019
@igdianov igdianov deleted the igdianov-default-distinct branch May 6, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant