Skip to content

Add duplicated property test case #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anotender
Copy link
Contributor

@anotender anotender commented Aug 29, 2019

Additional introspection test cases

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #178 into igdianov-fix-uppercase-properties will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##             igdianov-fix-uppercase-properties     #178      +/-   ##
=======================================================================
+ Coverage                                68.62%   68.66%   +0.03%     
  Complexity                                 509      509              
=======================================================================
  Files                                       33       33              
  Lines                                     2649     2652       +3     
  Branches                                   432      432              
=======================================================================
+ Hits                                      1818     1821       +3     
  Misses                                     666      666              
  Partials                                   165      165
Impacted Files Coverage Δ Complexity Δ
...phql/jpa/query/schema/impl/IntrospectionUtils.java 66.66% <100%> (+0.9%) 12 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89eb5f...08004b7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #178 into igdianov-fix-uppercase-properties will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##             igdianov-fix-uppercase-properties     #178      +/-   ##
=======================================================================
+ Coverage                                68.62%   68.66%   +0.03%     
  Complexity                                 509      509              
=======================================================================
  Files                                       33       33              
  Lines                                     2649     2652       +3     
  Branches                                   432      432              
=======================================================================
+ Hits                                      1818     1821       +3     
  Misses                                     666      666              
  Partials                                   165      165
Impacted Files Coverage Δ Complexity Δ
...phql/jpa/query/schema/impl/IntrospectionUtils.java 66.66% <100%> (+0.9%) 12 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89eb5f...08004b7. Read the comment docs.

@igdianov igdianov merged commit f32deb4 into introproventures:igdianov-fix-uppercase-properties Aug 30, 2019
igdianov pushed a commit that referenced this pull request Aug 31, 2019
igdianov added a commit that referenced this pull request Sep 8, 2019
* fix: support uppercase attribute names introspection

* fix: make getFieldName private

* fix: polish

* Add duplicated property test case (#178)

* fix: add test case for private getter  (#175)

* fix: add test case for private getter

* fix: polish test

* fix: refactor IntrospectionUtils

* fix: remove redundant code

* fix: polish IntrospectionUtils

* polish IntrospectionUtils

* fix: use JPA's ManagedType for entity introspection

* fix: cannot find symbol compile error

* fix: cannot find symbol   symbol:   method isEmpty()

* fix: add protected getter test case

* fix: add ignored attribute property descriptor tests

* fix: polish IntrospectionUtils

* fix: add protectedGetter to CalculatedEntityTests

* fix: refactor ObjectValue conversion

* fix: refactor persistent attribute detection

* fix: remove redundant code persistent detection logic

* fix: add introspection support for protected getter methods

* feat: refactor class introspection utils

* Add custom metamodel test case

* fix: refactor IntrospectionUtils to EntityIntrospector

* fix: add ArrayUtil test coverage

* fix: add ReflectionUtil tests

* fix: add ClassIntrospector tests

* fix: add ClassUtil tests

* fix: filter static methods

* fix: failing test methods

* fix: add ObjectUtil tests

* feat: add scanStatics option to ClassIntrospector

* fix: add test coverage for annotation descriptors

* fix: add constructor and property descriptor tests

* fix: polish ClassIntrospectorTest format

* fix: add PropertyDescriptor tests

* fix: add PropertyDescriptor equals and hashCode

* fix: add ConstructorDescriptor tests

* fix: add PropertyDescriptor equals and hashCode tests

* fix: add AnnotationDescriptor tests

* fix: add FieldDescriptor tests

* fix: add MethodDescriptor tests

* fix: add BeanUtil test coverage

* fix: add missing PropertyDescriptorTest coverage

* fix: PropertyDecriptor NPE check

* fix: add basic introspection tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants