Skip to content

Add fix and test case for orderBy argument as a variable #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anotender
Copy link
Contributor

Fixes #194

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #195 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #195      +/-   ##
============================================
- Coverage     73.68%   73.64%   -0.04%     
- Complexity      874      876       +2     
============================================
  Files            50       50              
  Lines          3701     3703       +2     
  Branches        627      623       -4     
============================================
  Hits           2727     2727              
- Misses          696      697       +1     
- Partials        278      279       +1
Impacted Files Coverage Δ Complexity Δ
...a/query/schema/impl/QraphQLJpaBaseDataFetcher.java 75.82% <100%> (+0.2%) 170 <6> (+3) ⬆️
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 91.2% <100%> (ø) 118 <0> (ø) ⬇️
.../graphql/jpa/query/introspection/Constructors.java 78% <0%> (-4%) 14% <0%> (-1%)
...tures/graphql/jpa/query/introspection/Methods.java 80.43% <0%> (-0.42%) 13% <0%> (ø)
...es/graphql/jpa/query/introspection/Properties.java 88.15% <0%> (-0.16%) 24% <0%> (ø)
...ntures/graphql/jpa/query/introspection/Fields.java 96.66% <0%> (-0.11%) 11% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33da4bb...7645281. Read the comment docs.

Copy link
Collaborator

@igdianov igdianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR @anotender! Thank you for contribution!

@igdianov igdianov merged commit 2a01382 into introproventures:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrderBy argument not recognized when supplied as a variable
2 participants