Skip to content

feat(GH-208): added EQ_, NE_, STARTS_, LIKE_, ENDS_ case insensitive string match criteria #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

igdianov
Copy link
Collaborator

This PR adds support for case insensitive string match predicate criteria, i.e. EQ_, NE_, STARTS_, LIKE_, ENDS_.

This modifier with force the string value to lower case and apply JPA lower criteria for case insensitive string match in the query.

Fixes #208

@igdianov igdianov self-assigned this Oct 21, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #210 into master will increase coverage by 0.29%.
The diff coverage is 86.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #210      +/-   ##
============================================
+ Coverage     73.76%   74.05%   +0.29%     
- Complexity      878      882       +4     
============================================
  Files            50       50              
  Lines          3720     3754      +34     
  Branches        627      628       +1     
============================================
+ Hits           2744     2780      +36     
+ Misses          698      696       -2     
  Partials        278      278
Impacted Files Coverage Δ Complexity Δ
...graphql/jpa/query/schema/impl/PredicateFilter.java 100% <100%> (ø) 7 <2> (+2) ⬆️
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 91.62% <100%> (+0.35%) 118 <0> (ø) ⬇️
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 59.5% <53.33%> (+0.63%) 112 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ab48e...6757659. Read the comment docs.

@igdianov igdianov merged commit 53c84dc into master Oct 21, 2019
@igdianov igdianov deleted the igdianov-add-case-insensitive-string-predicates branch October 21, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to force lower on string LIKE evaluation?
1 participant