-
Notifications
You must be signed in to change notification settings - Fork 54
fix(GH-233): Support Inline optional search criteria for singular and plural attributes #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
============================================
+ Coverage 70.86% 72.33% +1.47%
- Complexity 957 1025 +68
============================================
Files 66 71 +5
Lines 4434 4674 +240
Branches 661 674 +13
============================================
+ Hits 3142 3381 +239
+ Misses 1013 1005 -8
- Partials 279 288 +9 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
will result in
will return filtered books for each author
will sort authors by name in ASC order with books title in DESC order:
will return the following result:
In order to support inline search criteria with optional association, the framework is now using GraphQL Java Dataloader in order to optimize query perfromance.