Skip to content

fix(GH-38): Support JPA @ElementCollection annotation with @Embeddable generic type #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented Jun 6, 2020

Fixes #38

@igdianov igdianov self-assigned this Jun 6, 2020
@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #270 into master will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
- Coverage     72.28%   72.24%   -0.04%     
- Complexity     1029     1031       +2     
============================================
  Files            71       72       +1     
  Lines          4690     4698       +8     
  Branches        670      672       +2     
============================================
+ Hits           3390     3394       +4     
- Misses         1013     1017       +4     
  Partials        287      287              
Impacted Files Coverage Δ Complexity Δ
...ures/graphql/jpa/query/schema/model/book/Book.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...graphql/jpa/query/schema/model/book/Publisher.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../jpa/query/schema/impl/GraphQLJpaQueryFactory.java 78.36% <ø> (ø) 220.00 <0.00> (ø)
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 88.71% <75.00%> (+0.05%) 129.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40e94f...a4faa3d. Read the comment docs.

@igdianov igdianov merged commit 04e07c3 into master Jun 6, 2020
@igdianov igdianov deleted the fix-GH-38-add-embedded-generic-collection branch June 6, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JPA @ElementCollection annotation with @Embeddable generic attributes
1 participant