Skip to content

fix: support EQ/NE nullable criteria values for Java scalars #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented Apr 7, 2022

Add support for types to build EQ/NE predicates for Java scalars with null values

  • Boolean.class
  • Byte.class
  • Character.class
  • Double.class
  • Float.class
  • Integer.class
  • Long.class
  • Short.class
  • BigInteger.class
  • BigDecimal.class
  • String.class
  • Date.class
  • LocalDate.class
  • LocalDateTime.class
  • ZonedDateTime.class
  • Instant.class
  • LocalTime.class
  • Calendar.class
  • OffsetDateTime.class
  • java.sql.Date.class
  • java.sql.Time.class
  • java.sql.Timestamp.class
  • UUID.class

See tests for details..

@igdianov igdianov self-assigned this Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #302 (1ead08e) into master (ae420ed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #302      +/-   ##
============================================
+ Coverage     74.68%   74.69%   +0.01%     
  Complexity     1087     1087              
============================================
  Files            72       72              
  Lines          4862     4864       +2     
  Branches        698      698              
============================================
+ Hits           3631     3633       +2     
  Misses          918      918              
  Partials        313      313              
Impacted Files Coverage Δ
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 62.31% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae420ed...1ead08e. Read the comment docs.

@igdianov igdianov merged commit 82e5210 into master Apr 7, 2022
@igdianov igdianov deleted the fix-nullable-eq-ne-java-scalars branch April 7, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant