Skip to content

Refactor SchemaBuilder using Introspection #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented Mar 11, 2019

Simplifying class introspection using BeanInfo and PropertyDescriptor

@igdianov igdianov self-assigned this Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #86 into master will decrease coverage by 0.31%.
The diff coverage is 92.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     62.83%   62.52%   -0.32%     
+ Complexity      337      314      -23     
============================================
  Files            32       32              
  Lines          1924     1900      -24     
  Branches        297      286      -11     
============================================
- Hits           1209     1188      -21     
- Misses          584      585       +1     
+ Partials        131      127       -4
Impacted Files Coverage Δ Complexity Δ
...a/query/schema/impl/QraphQLJpaBaseDataFetcher.java 72.11% <100%> (ø) 99 <0> (ø) ⬇️
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 87.12% <100%> (+0.13%) 85 <8> (-10) ⬇️
...phql/jpa/query/schema/impl/IntrospectionUtils.java 84.37% <84.37%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cbf29c...91ee88a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #86 into master will decrease coverage by 0.31%.
The diff coverage is 92.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     62.83%   62.52%   -0.32%     
+ Complexity      337      314      -23     
============================================
  Files            32       32              
  Lines          1924     1900      -24     
  Branches        297      286      -11     
============================================
- Hits           1209     1188      -21     
- Misses          584      585       +1     
+ Partials        131      127       -4
Impacted Files Coverage Δ Complexity Δ
...a/query/schema/impl/QraphQLJpaBaseDataFetcher.java 72.11% <100%> (ø) 99 <0> (ø) ⬇️
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 87.12% <100%> (+0.13%) 85 <8> (-10) ⬇️
...phql/jpa/query/schema/impl/IntrospectionUtils.java 84.37% <84.37%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cbf29c...91ee88a. Read the comment docs.

@igdianov igdianov merged commit 493f65d into master Mar 11, 2019
@igdianov igdianov deleted the refactor-introspection branch March 11, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant