fix(doi link): rely on API links to display correct DOI link per record version#3356
Merged
fenekku merged 1 commit intoinveniosoftware:masterfrom Mar 9, 2026
Conversation
…rd version This is really to fix DOI links of versions in environment where `DATACITE_TEST_MODE = True` .
Contributor
Author
|
When merged, I will backport to v13 |
Contributor
Author
|
Actually wait on this. I will also fix the citation link. |
fenekku
changed the title
Contributor
Author
|
Actually the fix for the citation will be in invenio-rdm-records (and it's hard to make it nice, so will take more time and I will put it on the backburner). This can be reviewed. |
fenekku
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really to fix DOI links of versions in environment where
DATACITE_TEST_MODE = True. In that case, the visible DOI links have to be tohttps://handle.test.datacite.org/<prfix>/<suffix>and nothttps://doi.datacite.org/<prefix>/<suffix>.On our side the reported problem is well captured by this screenshot where green circles are good but red circles were bad:
[edit]
The citation problem is fixed by inveniosoftware/invenio-rdm-records#2269