Skip to content

Conversation

@Gustl22
Copy link
Contributor

@Gustl22 Gustl22 commented Jun 18, 2025

Closes #710

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@docs-page
Copy link

docs-page bot commented Jun 18, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~915

Documentation is deployed and generated using docs.page.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@Gustl22
Copy link
Contributor Author

Gustl22 commented Jun 18, 2025

I didn't write a test. I suppose it would be something like

    test('AggregateChangelog', () async {
      final changelog = AggregateChangelog(
        testWorkspace,
        config.description,
        dateSlug,
        pendingPackageUpdates,
        logger,
        config.path,
      );

      final read = await changelog.read();
      expect(read, '''
# Change Log
...etc.
''');
    });

Not quite sure how to mock these things and where to put this.

@github-actions github-actions bot added the needs attention OP has responded and the issue needs looking at again. label Jun 18, 2025
@spydon spydon merged commit 4b840c7 into invertase:main Jun 19, 2025
9 checks passed
@Gustl22 Gustl22 deleted the 710-windows-version branch June 20, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs attention OP has responded and the issue needs looking at again.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: melos version creates wrong workspace CHANGELOG.md entry on Windows due to CRLF

2 participants