requestAuthorizationWithOptions before registerForRemoteNotifications

[cark1]

Summary

Fixes #2657

This pull request solves the problems with request permission and registerForRemoteNotifications in messaging module.
When these methods are called, they simply fail without throwing any warnings or errors. Because of this, it was impossible to get the FCMToken.

The problem was that [[UIApplication sharedApplication] registerForRemoteNotifications]; should be called after [[UNUserNotificationCenter currentNotificationCenter] requestAuthorizationWithOptions as described in the documentation

There is some code duplication in this commit, but I think that is better for now, to help the reviewers.

Checklist

• Supports Android
• Supports iOS
• e2e tests added or updated in packages/**/e2e
• Flow types updated
• Typescript types updated

Test Plan

After calling request permission and registerForRemoteNotifications a FCMToken is returned by messaging().getToken()

Release Plan

[CATEGORY][type] [LOCATION] - Message

[ IOS] [ BUGFIX] [MESSAGING] - Solves the problems with request permission and registerForRemoteNotifications in messaging module.

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Donate via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️
• 👉 Contribute; see our contributing guide

[claassistantio]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Salakar
❌ Simone Carcone

---

Simone Carcone seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[mikehardy]

Fabulous - I think there are many reasons for the issue linked but if you've tested this as a fix for some of them, great! Thanks for the PR

[cark1]

Fabulous - I think there are many reasons for the issue linked but if you've tested this as a fix for some of them, great! Thanks for the PR

Yes, I think so, but after this commit of Salakar, probably this bug is the most frequent (reading the last messages)

[codecov]

Codecov Report

Merging #3017 into master will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3017      +/-   ##
=========================================
+ Coverage   89.83%   90.1%   +0.27%     
=========================================
  Files         109     109              
  Lines        3381    3381              
=========================================
+ Hits         3037    3046       +9     
+ Misses        344     335       -9

[Salakar]

Thank you for figuring this out, duplication is fine for now to get this fixed. I'll make a note on our internal tracker to see if we can de-dupe after we release Notifications - as we'll look at adding some internal changes to messaging to make it integrate better.