[Android] App crashing when opening a notification

[Markuson]

Hi all,

I'm starting to work with this library and integrating it to react-native-firebase.

What I found is, when pressing to a custom created notification via notifee.displayNotification(), tha app just crashes. However, if i launch a notification directly from firebase console. I press and it just opens the app.

What I'm missing?? I've been looking for some information throught the issues and the documentation but i did not find anything.

Thanks.

[helenaford]

Hi, it's hard to know what exactly is wrong without knowing more details. A few questions:

• Is this happening in dev?
• Do you have any log output?
• Is it crashing when the app is in the foreground/background/quit/all?
• What properties does your custom notification have?
• Can you show a snapshot of your code, in particular, displayNotification(...) and if you have any listeners, if you could paste those here too.

I can see if there's anything obvious going on, or you can try to recreate the scenario using https://github.com/mikehardy/rnfbdemo and send us the link to your fork. All you have to do is edit NotifeeApp.js, and run notifee-demo.sh .

[Markuson]

Hi,

• This is happening in Dev, yes. I don't have the license yet, cause we want to test the library and confirm it does everything we need before purchasing it.

• The app is crashing allways. When the notification pops out, if i press on it, it just crashes without logs.

see some snapshots of my code below:

import firebaseMessaging from '@react-native-firebase/messaging';
import { Platform } from 'react-native';
import { customNotification } from './customNotification'
import notifee, {EventType} from '@notifee/react-native';

export const messaging = firebaseMessaging();

class fcmHelper {
  register = (
    onRegister: any,
    onNotification: any,
    onOpenNotification: any,
  ) => {
    this.checkPermission(onRegister);
    this.createNoitificationListeners(
      onRegister,
      onNotification,
      onOpenNotification,
    );
  };

  registerAppWithFCM = async () => {
    if (Platform.OS === 'ios') {
      await messaging.registerDeviceForRemoteMessages();
      await messaging.setAutoInitEnabled(true);
    }
  };

  checkPermission = async (onRegister: any) => {
    const authorizationStatus = await messaging.hasPermission();
    if (authorizationStatus === firebaseMessaging.AuthorizationStatus.AUTHORIZED) {
      //if user has permission
      console.log('fcm checkpermission true');
      this.getToken(onRegister);
    } else {
      //if user don't have permission
      console.log('fcm checkpermission false');
      this.requestPermission(onRegister);
    }
  };

  getToken = async (onRegister: (arg0: string) => void) => {
    const fcmToken = await messaging.getToken();
    if (fcmToken) {
      onRegister(fcmToken);
      console.log('User have a device token: fcm', fcmToken);
      customNotification.createChannel();
    } else {
      console.log('User does not have a device token: fcm');
    }
  };

  requestPermission = async (onRegister: any) => {
    if (messaging.isDeviceRegisteredForRemoteMessages) {
      await messaging.registerDeviceForRemoteMessages();
    }
    const authorizationStatus = await messaging.requestPermission({
      alert: true,
    });
    if (
      authorizationStatus === firebaseMessaging.AuthorizationStatus.AUTHORIZED || firebaseMessaging.AuthorizationStatus.NOT_DETERMINED
    ) {
      // this.getToken(onRegister)
      const token = await messaging.getToken();
      onRegister(token);
      console.log('Token fcm', token);
      customNotification.createChannel();
    } else if (
      authorizationStatus === firebaseMessaging.AuthorizationStatus.PROVISIONAL
    ) {
      console.log('User has provisional notification permissions.');
    } else {
      console.log('User has notification permissions disabled');
    }
  };

  deletedToken = () => {
    messaging.deleteToken().catch(error => {
      console.log('Delected token error fcm', error);
    });
  };

  createNoitificationListeners = (
    onRegister: any,
    onNotification: any,
    onOpenNotification: any,
  ) => {
    // Background
    messaging.onNotificationOpenedApp(remoteMessage => {
      console.log('OPENED FROM BACKGROUND!')
    });

    // Quit state
    notifee.getInitialNotification().then((remoteMessage:any) => {
      console.log('Opened from Quit or Background state', remoteMessage);
 
    })

    // ForeGround
    this.messageListener = messaging.onMessage(async (remoteMessage) => {
      console.log('FCM Foreground notification:', remoteMessage);
      const lastMessage = await customNotification.launch(remoteMessage.data);
      console.log('Fcm: last message launchedddd', lastMessage);
    })

    // Triggered when have  new token
    messaging.onTokenRefresh(token => {
      console.log('token was refreshed: fcm', token);
      onRegister(token);
      customNotification.createChannel();
    });
  };

  unRegister = () => {
    this.messageListener()
  };

  backgroundListener = () => {
    messaging.setBackgroundMessageHandler(async payload => {
      console.log('Fcm: message received in background', payload);
      const lastMessage = await customNotification.launch(payload.data);
      console.log('Fcm: last message launched', lastMessage);
      // return Promise.resolve(true);
    });
  };
}


export const FCMHelper = new fcmHelper();

here is how I create the notification with notifee:

import notifee, { AndroidLaunchActivityFlag, EventType } from '@notifee/react-native';
import { Platform } from 'react-native';

class CustomNotification {

    channel = 'default'

    backgroundEvent = () => {
        notifee.onBackgroundEvent(async ({ type, detail }) => {
            const { notification, pressAction } = detail;
            if (type === EventType.ACTION_PRESS) {
                console.log("ACTION PRESS: ", pressAction)
            }
        })
        return Promise.resolve(true);
    }

    cancel = async (id: string | undefined) => {
        if (id) {
            await notifee.cancelNotification(id);
        }
    }

    createChannel = async (channel: string = this.channel) => {
        if (Platform.OS == 'android') {
            const channelId = await notifee.createChannel({
                id: channel,
                name: channel,
            });

            console.log('FCM Notification Android, channel name: ', channelId)
        }
    }

    launch = async (data: any, channelId: string = this.channel) => {
            const id = String(Date.now())
            const { body, title } = data

            console.log("launch CustonNotification: ", data)
            return await notifee.displayNotification({
                id,
                title,
                body,
                android: {
                    channelId,
                    smallIcon: 'smallicon_example',
                    groupId: channelId,
                    pressAction: {
                        id: 'default',
                        launchActivity: 'default',
                        launchActivityFlags: [AndroidLaunchActivityFlag.SINGLE_TOP],
                    },
                },
            });
        }
    }
}

export const customNotification = new CustomNotification

FCMHelper.backgroundListener(); is called on index.js and FCMHelper.registerAppWithFCM(); is called on App.tsx on componentDidMount().

Also, my app it's managing redux. Don't know if coud be important.

[Markuson]

hey,
I just realized Deleting the pressAction part on the notification it's not crashing. It don't do nothing when pressing but et least it's not crahing.

So it should be there the problem. I would be missing something...

[mikehardy]

Hi there! There are always logs when there is a crash - on android watch unfiltered adb logcat while you have the emulator running and trigger the crash, you should see a stack trace?

[Markuson]

Ok, Sorry, i didn't know about logcat... I'm newbie with React-native.

On logcat i can see the fllowing:

03-01 14:05:04.540 22058 22058 E NOTIFEE : (ReceiverService): Launch Activity for notification does not exist ('default').
03-01 14:05:04.543 22058 22058 E AndroidRuntime: FATAL EXCEPTION: main
03-01 14:05:04.543 22058 22058 E AndroidRuntime: Process: com.myapp, PID: 22058
03-01 14:05:04.543 22058 22058 E AndroidRuntime: java.lang.RuntimeException: Unable to start service app.notifee.core.ReceiverService@309bd3f with Intent { act=app.notifee.core.ReceiverService.PRESS_INTENT cmp=com.myapp/app.notifee.core.ReceiverService (has extras) }: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Class.getName()' on a null object reference

[mikehardy]

react-native is a lot to learn all at once, given that problems frequently break the cross-platform abstraction and require iOS/Objective-C or Android/Java skills plus all the infrastructure knowledge like adb logcat. Well, you have a new trick now anyway :-). logcat is very very useful

One thing that might be even more useful is the actual stack frames, not just the Exception message. Could you post the complete stack trace?

So - the error - this looks like a multi-bug to me - Notifee code not being defensive enough about requested Activity, at least in Debug mode it should present much more useful diagnostic information (like via logbox, not logcat) vs crashing, and in production at minimum it should not crash

Something is unexpected about your native project setup - if you run this script from a clone of this repo does it work? https://github.com/mikehardy/rnfbdemo/blob/master/notifee-demo.sh (it should work!)

If it does, then the thing to examine is android/app/src/main/AndroidManifest.xml to see how the Activities are set up I think

[Markuson]

there's many things happening on the logcat... sooo many things... I just get lost on it.

I'll paste here a piece of it. No idea if it will be enough.

03-01 14:38:46.195 12247 12247 E NOTIFEE : (ReceiverService): Launch Activity for notification does not exist ('default').
03-01 14:38:46.200 12247 12247 E AndroidRuntime: FATAL EXCEPTION: main
03-01 14:38:46.200 12247 12247 E AndroidRuntime: Process: com.myapp, PID: 12247
03-01 14:38:46.200 12247 12247 E AndroidRuntime: java.lang.RuntimeException: Unable to start service app.notifee.core.ReceiverService@b216bbe with Intent { act=app.notifee.core.ReceiverService.PRESS_INTENT cmp=com.myapp/app.notifee.core.ReceiverService (has extras) }: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Class.getName()' on a null object reference
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:4337)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.app.ActivityThread.access$1800(ActivityThread.java:238)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1952)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:223)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7698)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:952)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Class.getName()' on a null object reference
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.content.ComponentName.<init>(ComponentName.java:132)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.content.Intent.<init>(Intent.java:6870)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at app.notifee.core.ReceiverService.nz_n(SourceFile:34)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at app.notifee.core.ReceiverService.onStartCommand(SourceFile:44)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:4319)
03-01 14:38:46.200 12247 12247 E AndroidRuntime: 	... 8 more

[mikehardy]

I edited it down to just the relevant parts of the exception - and it's gold! thank you @helenaford possibly of interest? I won't have time to fix the Notifee library part of the issue for a while so can't volunteer for that one

@Markuson I still believe this should not happen for your app and there is a configuration issue in your app. It should be possible to get this to work, I literally tested it on my app just now and it works. We should not crash of course, but there should be nothing blocking you from examining the AndroidManifest.xml / project generated from notifee-demo.sh compared with yours and finding a difference. There must be a difference and finding+fixing it should get you going

[Markuson]

thanks for your help @mikehardy !

I've found react-native-splash-screen could cause some problems. we are using this library, I'll try to do some research on this.

Also, there's many things in our AndroidManifest.xml. many of it out of my control so maybe I should find some help on this through my colleagues.

[mikehardy]

Indeed! I am vocal in my assertion that react-native-splash-screen should never be used at this point crazycodeboy/react-native-splash-screen#289 (comment) (with recommendation on alternative)

That may help in this case, as the way an Android app starts up is directly affected by splash screens and this crash is definitely in the area of the Android app starting up