Skip to content

Support for mono-repo structure in ionic scripts #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandyscarney opened this issue Feb 12, 2018 · 2 comments
Closed

Support for mono-repo structure in ionic scripts #2988

brandyscarney opened this issue Feb 12, 2018 · 2 comments

Comments

@brandyscarney
Copy link
Member

From @johneast on February 11, 2018 0:17

Ionic version: (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[X] 3.x
[ ] 4.x

I'm submitting a ... (check one with "x")
[ ] bug report
[X] feature request

Current behavior:

When working on a system that has multiple apps, all using the same API it is convenient to have all code in a mono-repo rather than one git repo per application.

Given the following folder structure:

|-my-project/
|----apps/
|--------awesome-app1/
|------------(ionic app in here)
|--------awesome-app2/
|------------(ionic app in here)
|----libs/
|--------services/
|------------(shared service code)
|--------model/
|------------(shared model and business logic)

It would be good if the package.json file in the my-project folder could describe all of the dependencies across all of the apps. This way only one node_modules folder in my-project would be needed, instead currently each app needs it's own node_modules. I know it's possible to have multiple apps in a mono repo, sharing a libs folder and the same node_modules folder in angular. It's a shame the benefits are lost as soon as I add an Ionic project into the mono repo

Given that IonicPro requires the app code to be pushed into a git repo in order for it to become available in IonicView, then I'm assuming the above structure won't work with IonicView.

Copied from original issue: ionic-team/ionic-framework#13999

@imhoffd
Copy link
Contributor

imhoffd commented Feb 12, 2018

Thanks @johneast, I appreciate the feature request! Could you explain a bit more where there's a lack of support for monorepos? I'm assuming it's a CLI issue.

As for Pro, I know the Ionic Pro team is aware of the request. I am trying to get more details now, but it would help to understand your use case better.

Related to #2987

@imhoffd
Copy link
Contributor

imhoffd commented Feb 12, 2018

Consolidating to this mega-issue 👉 #2232

@johneast Let's please continue the discussion there. Thanks! 😄

@imhoffd imhoffd closed this as completed Feb 12, 2018
imhoffd added a commit that referenced this issue Feb 14, 2018
This doesn't fix every issue Ionic apps have in monorepos, but it's a
good start from the CLI.

See #2232 for more info.

address #2987
address #2988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants