Skip to content

fix(angular): always provide the project name fallback #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2020
Merged

fix(angular): always provide the project name fallback #4349

merged 3 commits into from
Mar 14, 2020

Conversation

SchnWalter
Copy link
Contributor

This MR ports some changes from #4311, which is no longer required after the --multi-app feature was introduced.

With this MR, the Angular specific Runner commands will consistently provide all defaults passed to the Angular CLI in the createOptionsFromCommandLine method.

Closes #4192

@SchnWalter SchnWalter mentioned this pull request Mar 14, 2020
Closed
@imhoffd imhoffd merged commit c498f59 into ionic-team:develop Mar 14, 2020
@SchnWalter SchnWalter deleted the fix-project-name-fallback branch March 14, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhoffd imhoffd imhoffd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular*CLI.buildArchitectCommand should not fallback to app
2 participants
@SchnWalter @imhoffd