Skip to content

docs(breadcrumbs): fix theming headings #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 14, 2022
Merged

docs(breadcrumbs): fix theming headings #2526

merged 8 commits into from
Sep 14, 2022

Conversation

liamdebeasi
Copy link
Contributor

  • Updates "Styling" heading to read "Theming"
  • Updates the "Color Property" heading to display as a sub-heading in "Styling"

@vercel
Copy link

vercel bot commented Sep 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 7:48PM (UTC)

@liamdebeasi liamdebeasi marked this pull request as ready for review September 1, 2022 21:07
averyjohnston
averyjohnston approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "CSS Properties" header under "Color Property" also be changed to a 3rd level heading? Otherwise/including that, LGTM.

@liamdebeasi
Copy link
Contributor Author

Good catch, just fixed that.

@brandyscarney
Copy link
Member

brandyscarney commented Sep 1, 2022 •
edited
Loading

Can we rename the styling folder to theming to make it easier to find later on?

Also are we set on Color Property vs Colors or something similar?

@liamdebeasi
Copy link
Contributor Author

I updated the directory name.

I don't really have a preference for Color Property vs Colors. I'm fine with whatever you think is best.

brandyscarney
brandyscarney reviewed Sep 2, 2022
View reviewed changes
brandyscarney
brandyscarney reviewed Sep 2, 2022
View reviewed changes
@brandyscarney brandyscarney mentioned this pull request Sep 6, 2022
Merged
brandyscarney
brandyscarney reviewed Sep 9, 2022
View reviewed changes
@liamdebeasi @brandyscarney
Update docs/api/breadcrumbs.md
3d9af42 
Co-authored-by: Brandy Carney <[email protected]>
@brandyscarney
Copy link
Member

Pushed some changes and approved, maybe we need @sean-perkins to help us update this for the jp version?

@liamdebeasi liamdebeasi merged commit 70045f8 into main Sep 14, 2022
@liamdebeasi liamdebeasi deleted the liamdebeasi-patch-1 branch September 14, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@averyjohnston averyjohnston averyjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liamdebeasi @brandyscarney @averyjohnston