docs(menu): add component playgrounds for side & multiple #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
If the multiple menu issue is a blocker, we can probably ship only the side playground. |
|
Verifying that it's still an issue on Angular & JavaScript StackBlitz. But it works fine when using Framework v7. |
brandyscarney
requested review from
a team and
averyjohnston
and removed request for
a team and
averyjohnston
|
Thanks for bringing this up @thetaPC! I actually managed to fix the demos and get them working for v7 but this branch is too different from |
brandyscarney
force-pushed
the
docs-menu-playgrounds
branch
from
2bbbc94 to
157b758
Compare
|
Closing in favor of #3049 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the menu playwright migration I noticed there were no usage examples in the docs on how to call open on a menu when you have multiple menus.
This PR adds the following two playgrounds:
The first one just shows an example of how to change the side to
endwhich is more of a buildup to the next one. Multiple menus has two menus on thestartside and one on theendside to show how you can useMenuControllerto open a menu by id or side.