docs(slides): update Angular migration guide to be compatible with Swiper 9 #2828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liamdebeasi
suggested changes
Mar 14, 2023
liamdebeasi
reviewed
Mar 14, 2023
Co-authored-by: Liam DeBeasi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcut: https://ionic-docs-git-fw-3513-angular-ionic1.vercel.app/docs/angular/slides
This was a more significant overhaul than the React and Vue migrations because Swiper has removed its Angular component completely, in favor of Swiper Element.
Updating the example repo linked at the bottom of the docs will be done later. Those changes will be merged into
mainat the same time as this one.If you want to play around with Swiper Element, here's the repo I've been using to test. Note that you'll also need this fix in Swiper for any of the functionality to work within an Ionic app; at the time of writing, this fix has been merged into
mainbut not officially released. (I've written this guide with the assumption that it'll be released by the time our new docs go live.)Here are the steps I wound up having to take to get the fix into the test repo:
https://github.com/nolimits4web/swiper.gitnpm install && npm run build.npm pack. This will create a compressed archive of the built project called “swiper-9.1.0.tgz”.npm install [path to compressed archive]