Skip to content

bug: Alert wrapper in dark mode is still using light background #18658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandyscarney opened this issue Jun 28, 2019 · 1 comment · Fixed by #18709
Closed

bug: Alert wrapper in dark mode is still using light background #18658

brandyscarney opened this issue Jun 28, 2019 · 1 comment · Fixed by #18709

Comments

@brandyscarney
Copy link
Member

Bug Report

Ionic version:

[x] 4.x

Current behavior:
Alert overlay background uses --ion-overlay-background-color for the background but does not fallback to the step color in Material Design only.

Screen Shot 2019-06-28 at 11 35 21 AM

Expected behavior:

    --background: var(--ion-overlay-background-color,#fff);

This should behave like iOS, falling back to a step color.

Steps to reproduce:

Run the conference app in dark mode.

Related code:

insert short code snippets here

Other information:

Ionic info:

insert the output from ionic info here
@ionitron-bot
Copy link

ionitron-bot bot commented Aug 4, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant