Skip to content

Scrolling does not work in IE for certain mice #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesleycho opened this issue Dec 15, 2014 · 4 comments
Closed

Scrolling does not work in IE for certain mice #2728

wesleycho opened this issue Dec 15, 2014 · 4 comments
Assignees

Comments

@wesleycho
Copy link

This would require a minor change, and I will open a PR shortly for this that has been tested in a production app, but IE will fire the mousewheel event for certain mice, and the current set of listeners do not capture this situation.

wesleycho pushed a commit to wesleycho/ionic that referenced this issue Dec 15, 2014
Fix IE10 scroll issue. This addresses ionic-team#2728
wesleycho pushed a commit to wesleycho/ionic that referenced this issue Dec 15, 2014
Fix IE10 scroll issue. This addresses ionic-team#2728
@wesleycho wesleycho mentioned this issue Dec 15, 2014
@adamdbradley
Copy link
Contributor

You mentioned mousewheel is the issue, but the PR is for wheel. Have you tested this on desktop Chrome/Firefox/Safari, and the same for iOS Chrome, iOS Safari, Android <=4.3 and Android >=4.4? Android quite often fires off mouse events, so I'm curious what it does in this situation too.

https://developer.mozilla.org/en-US/docs/Web/Events/mousewheel
https://developer.mozilla.org/en-US/docs/Web/Events/wheel

@wesleycho
Copy link
Author

Sorry, I might have said the wrong event - I cherry-picked the commit, and this was investigation on hard manual testing by me.

@adamdbradley
Copy link
Contributor

This PR makes me nervous because of the many other issues it can cause on all the different browsers/devices. I'll probably keep this one open for a while as it'll take some heavy testing. So the more help we can get from the community the better. Thanks!

ajoslin pushed a commit that referenced this issue Feb 12, 2015
Fix IE10 scroll issue. This addresses #2728
@adamdbradley
Copy link
Contributor

Merged, thanks for the PR and research!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants