refactor(OpaqueToken): change deprecated import #11916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsogl
changed the title
danielsogl
changed the title
|
@danielsogl the PR does not pass "gulp validate" |
|
cc @danbucholtz |
|
@manucorporat I will take a look. Changing types from string to any should fix it. |
|
@manucorporat Any news? We changed this in our production Angular applications without any problems. |
|
@danbucholtz Notes from the last Angular 5 Beta 6
|
|
Thanks! Thanks, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
From the Angular 4 Beta 5 Changelog
OpaqueTokenis now deprecated, useInjectionToken<T>instead.Related to: #12813
Changes proposed in this pull request:
OpaqueTokenimport toInjectionTokennew OpaqueToken('')tonew InjectionToken<any>('')Ionic Version: 1.x / 2.x / 3.x
3.x