Skip to content

feat(generators): add --minimal flag #13119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 204 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
204 commits
Select commit Hold shift + click to select a range
a91a68e
style(util): remove commented out test css
brandyscarney Jun 12, 2017
47e3c70
fix(refresher): border should only show when pulled (#12015)
Manduro Jun 12, 2017
c10f72b
fix(keyboard): big keyboard/input refactor
manucorporat Jun 7, 2017
6dee17b
Merge branch 'keyboard-fixes'
manucorporat Jun 12, 2017
ef85ba6
fix(input): add correct translate3d for rtl
manucorporat Jun 12, 2017
8041eed
fix(input): use all supported attributes on both textareas and inputs…
Manduro Jun 13, 2017
9f86e10
fix(input): better handling of attributes
manucorporat Jun 13, 2017
dc958c3
fix(textarea): apply classes properly
manucorporat Jun 13, 2017
54ac2e3
fix(input): slightly longer delay for autofocus (#12037)
Manduro Jun 14, 2017
2791c40
chore(changelog): 3.4.0 release
danbucholtz Jun 15, 2017
f149c5e
chore(dependencies): update package version to 3.4.0
danbucholtz Jun 15, 2017
3564bcf
chore(github): update issue template plunkr to 3.4.0 version
danbucholtz Jun 15, 2017
7a1342c
fix(input): prevent duplicated tabIndex (#12043)
manucorporat Jun 15, 2017
2743c63
refactor(overlay): simplify focusOutActiveElement (#12023)
manucorporat Jun 15, 2017
c7645ee
feat(select): add compareWith Input for object value comparison (#11965)
zakton5 Jun 15, 2017
5a5da39
fix(highlight): selected tab might be null
manucorporat Jun 15, 2017
1a4aacf
chore(changelog): add upgrade instructions for 3.4.0
danbucholtz Jun 15, 2017
6193560
fix(sliding-item): super slow device does get correct classes
manucorporat Jun 15, 2017
63f728f
feat(item-reorder): add side support (#11642)
AmitMY Jun 15, 2017
8bd2f24
perf(item): button-effect is hidden for non buttons
manucorporat May 5, 2017
7803998
style(reorder): using const
manucorporat Jun 15, 2017
a8731df
fix(tabs): properly align tabs highlight (#11619)
dudeofawesome Jun 15, 2017
877d821
chore(changelog): fix typo, update deps to latest
danbucholtz Jun 16, 2017
1ca7df7
fix(themes): change default app-direction
brandyscarney Jun 16, 2017
5094fee
chore(ionic): release 3.4.1
brandyscarney Jun 16, 2017
70b5b6b
fix(rtl): use multi direction in order to override the default ltr
brandyscarney Jun 16, 2017
d8b65da
chore(ionic): release 3.4.2
brandyscarney Jun 16, 2017
e3a8d27
fix(select): floating label
manucorporat Jun 19, 2017
5cad965
feature(navigation): modify urls to support multiple root level navs/…
danbucholtz Jun 19, 2017
00fbded
chore(build): strictly enforce metadata
danbucholtz Jun 19, 2017
bcc85d9
chore(build): fix path issue in snapshot test
danbucholtz Jun 19, 2017
6f7acdb
docs(changelog): fix broken commit links
brandyscarney Jun 20, 2017
f39c381
fix(navigation): add isTab check to getSegmentsFromNav
danbucholtz Jun 20, 2017
0480f73
chore(nav): fix lint errors in test
danbucholtz Jun 20, 2017
58e1d79
refactor(app): refactor app slightly to maintain backwards compatibility
danbucholtz Jun 20, 2017
1beef75
refactor(navigation): refactor nav-controller-base to maintain backwa…
danbucholtz Jun 20, 2017
30f69c8
fix(navigation): fallback to name if component does not exist on segment
danbucholtz Jun 20, 2017
fba6ff0
add href for additional testing
danbucholtz Jun 20, 2017
86495e1
docs(api): angularjs to angular
janpio Jun 20, 2017
0f5c47d
feature(navigation): better browser back/forward button support
danbucholtz Jun 27, 2017
016b90d
fix(tabs): use segment if it exists even if component exists
danbucholtz Jun 27, 2017
bc7bb21
docs(menu): fix link to menucontroller
mhartington Jun 28, 2017
8dc08f9
fix(select): _inputUpdated should not be called manually
manucorporat Jun 28, 2017
a92d805
chore(changelog): 3.5.0 changelog
danbucholtz Jun 28, 2017
048af1b
chore(changelog): additional nav change details
danbucholtz Jun 28, 2017
5771543
chore(dependencies): update app-scripts to 1.3.11, add npm 5 support
danbucholtz Jun 28, 2017
a7e5fa7
chore(dependencies): lock file updated
danbucholtz Jun 28, 2017
486bff0
feat(navigation): support for named ion-nav/ion-tabs to improve url i…
danbucholtz Jun 29, 2017
48b3243
fix(navigation): mark as not transitioning on success in addition to …
danbucholtz Jun 29, 2017
04e78d8
fix(navigation): fix swipe-to-go-back
danbucholtz Jun 30, 2017
fce4422
fix(navigation): navs can have n child navs instead of just one
danbucholtz Jun 30, 2017
3f39e14
fix(tabs): have tabs behavior match nav when navigating back/forth vi…
danbucholtz Jul 3, 2017
eb830d4
chore(app): fix linting issues
danbucholtz Jul 3, 2017
efd5475
chore(lint): fix all code that doesn't pass tslint
danbucholtz Jul 5, 2017
d22d77b
fix(navigation): restore getActiveChildNav method to maintain old API…
danbucholtz Jul 6, 2017
5a4b351
chore(build): remove linting checks we do not want for dist
jgw96 Jul 6, 2017
e079f77
chore(build): use cross-spawn instead of spawn
jgw96 Jul 6, 2017
923e3b2
chore(build): import spawnSync from correct package
jgw96 Jul 6, 2017
3e3a00b
chore(lockfile): idk why this thing keeps updating
danbucholtz Jul 6, 2017
b5aa304
fix(sliding-item): ionSwipe event is fired (#12157)
manucorporat Jul 10, 2017
693c1c5
docs(content): type Sroll => Scroll (#12281)
janpio Jul 10, 2017
ad25cd1
fix(select): not activated on enter in input field
manucorporat Jul 10, 2017
08be9dc
fix(navigation): ts2.4 compatibility
RoopeHakulinen Jul 10, 2017
9ffc52b
chore(dependencies): recreate lockfile with npm 5.1
danbucholtz Jul 12, 2017
347c260
docs(events): fix syntax error (#12317)
pranjal-goswami Jul 13, 2017
6d8da0a
chore(generator): remove ionicPage for now (#12347)
mhartington Jul 13, 2017
2153940
chore(changelog): update to 3.5.1
danbucholtz Jul 13, 2017
acb6fac
chore(changelog): 3.5.2 release
danbucholtz Jul 13, 2017
889b49f
chore(changelog): 3.5.2 upgrade instructions
danbucholtz Jul 13, 2017
4c13535
chore(changelog): additional details about upgrading and updating app…
danbucholtz Jul 13, 2017
d23b9f7
docs(toast): add import statement in usage (#12278)
b264 Jul 13, 2017
f7fce5f
chore(changelog): update changelog to save app-scripts as devDependency
peterpeterparker Jul 14, 2017
ce46c24
chore(changelog): 3.5.2 changelog
danbucholtz Jul 13, 2017
2d49e10
fix(app): restore getActiveNav api
danbucholtz Jul 14, 2017
ab511c4
chore(dependencies): add angular/tsc-wrapper to package.json to avoid…
danbucholtz Jul 14, 2017
cec718c
chore(dependencies): removing tsc-wrapped since angular explicitely s…
danbucholtz Jul 14, 2017
c4e7552
chore(dependencies): update the lock file
danbucholtz Jul 14, 2017
5b9fe5e
chore(changelog): 3.5.3 release
danbucholtz Jul 14, 2017
961bfc3
chore(docs): add anchor links to documentation sub-sections (#12386)
samuelgoodell Jul 18, 2017
97f9522
fix(list): remove margin of MD buttons in ion-item-options (#12263)
Jul 21, 2017
a8ceee4
fix(navigation): reduce urls to minimum set of fields
danbucholtz Jul 22, 2017
519d657
chore(karma): fix duplicate console.log issue
danbucholtz Jul 24, 2017
add0c4e
fix(navigation): fix bug where that occurred when tab identifier and …
danbucholtz Jul 24, 2017
400aa54
feat(generators): refactor generators
mhartington Jul 25, 2017
4596dbe
fix(navigation): account for race conditions in developer's code
danbucholtz Jul 25, 2017
de0f9d5
fix(nav): make call to setPages return the promise so if it rejects i…
danbucholtz Jul 26, 2017
584afd0
fix(navigation): fix null pointer exceptions that would occur when de…
danbucholtz Jul 26, 2017
16f2ebe
chore(changelog): 3.6.0 changelog
danbucholtz Jul 27, 2017
e401997
chore(changelog): change --save to --save-dev for app-scripts
danbucholtz Jul 27, 2017
f605f0a
chore(changelog): add details about tabUrlPath to changelog
danbucholtz Jul 27, 2017
50beafa
docs(input): correct the `autocomplete` and `autocorrect` description…
kelvindart Aug 8, 2017
475b722
fix(generators): Update documentation URLs for templates
imhoffd Aug 9, 2017
17b3a39
chore(CI): ignore refactor branches
perrygovier Aug 10, 2017
1e9539b
chore(CI): don’t need to ingore `core/overlay` branch
perrygovier Aug 10, 2017
26b09f1
chore(CI): `branches` property must be a child of `build`
perrygovier Aug 10, 2017
b87d212
feat(datetime): add default picker value input
Aug 18, 2017
ae94f5e
test(datetime): add pickerDefault test
Aug 18, 2017
5bb3e73
test(datetime): add pickerDefault test
Aug 18, 2017
54cdf00
test(datetime): add pickerDefault test
Aug 18, 2017
1b9c3da
chore(issue template): add resources to the issue template
kensodemann Aug 29, 2017
0a6bb3b
fix(navigation): check existence of done transition callback (#12640)
soumak77 Aug 31, 2017
295fe78
docs(datetime): fix typo (#12776)
abdel-ships-it Aug 31, 2017
1069505
fix(navigation): ensure secondaryId always has a string value (#12641)
soumak77 Aug 31, 2017
ac4a043
docs(toolbar): fix a spelling error for toolbar-header (#12676)
jeffcressman Aug 31, 2017
846eb09
docs(nav-params): include import statements (#12657)
ceosion Aug 31, 2017
bd0c265
docs(content): correct content docs typo, "need" (#12707)
toddpress Aug 31, 2017
e3216da
docs(config): add statusbarPadding to config (#12168)
danielfliegauf Aug 31, 2017
6e64b8d
docs(modal): fix improper capitalization (#12321)
HenryDangPRG Aug 31, 2017
4911d9f
docs(nav-push): change property order (#12468)
janpio Aug 31, 2017
f4539aa
docs(datetime): add note about `Date().toISOString();` (#12501)
janpio Aug 31, 2017
7e8bd5a
docs(platform): make more readable
janpio Sep 1, 2017
4f49f27
docs(modal): add example of nested ionNav in modal
wbhob Sep 1, 2017
4d786b3
docs(modal): fix trailing space
mhartington Sep 1, 2017
b809665
fix(slider): guard the processing of _slides
kensodemann Sep 5, 2017
04fe92c
chore(gitignore): update gitignore to includ .sourcemaps per new app-…
danbucholtz Aug 31, 2017
3187375
fix(navigation): fix popTo signature and make usage uniform
danbucholtz Sep 6, 2017
830f885
chore(release): update CHANGELOG.md and package.json
kensodemann Sep 7, 2017
f5ef1ca
fix(swiper): change var to let to avoid variable shadowing
kensodemann Sep 8, 2017
d0cad6b
fix(input): mark ion-input touched on blur instead of changed (#12812)
kensodemann Sep 11, 2017
ac04710
chore(dependencies): update to latest angular and typescript
danbucholtz Sep 12, 2017
fdacbbf
chore(package): bump RXJS, zone.js (#12000)
danielsogl Sep 13, 2017
8c207e8
chore(dependencies): update lock file
danbucholtz Sep 13, 2017
86e2742
doc(): fix demos, e2e, and app-script version
mhartington Sep 14, 2017
cfd9e3b
fix minor grammar (#12840)
Sep 15, 2017
468dcd3
chore(dependencies): updated the ol' lock file
danbucholtz Sep 15, 2017
59f97e7
chore(demos): remove unused gulp tasks (I hope)
danbucholtz Sep 15, 2017
3fb0371
docs(MenuToggle): fix navbar link (#12211)
WaveMeUp Sep 16, 2017
e2b3d75
docs(demos): add event target to searchbar demo (#12685)
coffeduong Sep 18, 2017
547ab8d
docs(LoadingController): add the import statement (#12910)
bot101 Sep 18, 2017
f2dc8b2
chore(): add information to issue template
kensodemann Sep 20, 2017
3b5c34c
chore(): fix typo in issue template
kensodemann Sep 24, 2017
288c00a
docs(modal-controller): use const instead of let (#12971)
danielsogl Sep 26, 2017
d028a29
docs(loading-controller): use const instead of let (#12970)
danielsogl Sep 26, 2017
a48d02a
docs(keyboard): cosmetically improve documentation (#12969)
danielsogl Sep 26, 2017
794d88d
docs(ionic-error-handler): cosmetically improve documentation (#12968)
danielsogl Sep 26, 2017
8621075
docs(haptic): cosmetically improve documentation (#12966)
danielsogl Sep 26, 2017
c7b2b18
docs(events): cosmetically improve documentation (#12965)
danielsogl Sep 26, 2017
b248eb7
docs(alert-controller): use const instead of let (#12964)
danielsogl Sep 26, 2017
66faa1d
docs(action-sheet-controller): use const instead of let (#12963)
danielsogl Sep 26, 2017
200fa93
docs(toast-controller): use const instead of let (#12962)
danielsogl Sep 26, 2017
b5bfda2
docs(slides): clarify how zooming works (#12932)
kensodemann Sep 26, 2017
4e56458
docs(nav-params): cosmetically improve documentation (#12972)
danielsogl Sep 26, 2017
9b5c0e0
chore(dependencies): update to latest angular
danbucholtz Sep 22, 2017
f42e81b
chore(dependencies): revert to ts 2.3.x
danbucholtz Sep 25, 2017
112d4f5
feat(): initial iphoneX support
mhartington Sep 26, 2017
eacc5d4
chore(): fix gulp task
mhartington Sep 26, 2017
70ab2a4
chore(app-scripts): update to latest nightly
brandyscarney Sep 27, 2017
4199acc
chore(dependencies): update to latest app-scripts
danbucholtz Sep 27, 2017
c08de08
chore(dependencies): update to latest
danbucholtz Sep 27, 2017
921ccbb
revert(item): revert the change from margin to padding right
brandyscarney Sep 27, 2017
521402b
chore(changelog): 3.0.0 changelog
danbucholtz Sep 28, 2017
108fc0f
docs(changelog): copy editing
brandyscarney Sep 28, 2017
fce5d8a
chore(dependencies): update app-scripts to 3.0.0 release
danbucholtz Sep 28, 2017
599bf3d
chore(build): minify/optimize demos by default, leave e2e non-minifie…
danbucholtz Sep 28, 2017
0a49648
style(cordova): fix indentation
brandyscarney Sep 27, 2017
1573043
chore(index): export ActionSheetButton
brandyscarney Sep 28, 2017
f1a676e
docs(): add more config values
surajkochale Sep 29, 2017
559f4d3
feat(datetime): default to now or max. Fixes #9846
mlynch Sep 29, 2017
9b3fb78
fix trailing whitespace
mlynch Sep 29, 2017
39e7da3
fix(datetime): set default to max if max before current only #9846
mlynch Sep 29, 2017
f6d6596
Remove fit
mlynch Sep 29, 2017
4db20a6
chore(): update to latest zone.js
kensodemann Sep 29, 2017
9c2181b
Merge branch 'datetime_default_value' of https://github.com/jacek-jas…
mlynch Sep 29, 2017
77fcaef
Updated initialValue and current time/max setup
mlynch Sep 29, 2017
c60588a
Merge branch 'jacek-jaskolski-datetime_default_value'
mlynch Sep 29, 2017
e5b3eb7
chore(): update changelog
kensodemann Sep 29, 2017
dac8870
chore(): clarify upgrade instructions
kensodemann Sep 29, 2017
e0c8309
fix(swiper): add safe-guards when user tries to zoom a slide without …
kensodemann Sep 29, 2017
0ba33d9
feat(alert): export AlertButton interface
alan-agius4 Aug 2, 2017
ad8d8ed
chore(demos): setting demos target to es5 to get around safari 10 `le…
perrygovier Oct 2, 2017
9d4c94a
docs(platform): update resize method docs
mhartington Oct 3, 2017
c38cc28
doc(platform): copy edit
mhartington Oct 3, 2017
2bd89fe
fix(navigation): unregister root navs when appropriate
danbucholtz Oct 3, 2017
c963745
fix(navigation): account for condition of toggling one view with tabs…
danbucholtz Oct 3, 2017
a77bb2c
fix(tabs): return promises where appropriate
danbucholtz Oct 3, 2017
2646ebe
fix(navigation): add defaultHistory support to ion-tabs
danbucholtz Oct 5, 2017
ac4dd6f
chore(dependencies): update lock file
danbucholtz Oct 6, 2017
9bfd286
chore(dependencies): update app-scripts version to run latest nightly…
danbucholtz Oct 6, 2017
199cb00
fix(action-sheet): fix action sheet so it will scroll when the option…
brandyscarney Oct 6, 2017
88b2e83
fix(virtual-scroll): flickering issue fixes
manucorporat Oct 6, 2017
70809ca
test(virtual-scroll): update tests
manucorporat Oct 6, 2017
b180351
feat(input): add dir attribute for different language directions (#13…
AmitMY Oct 6, 2017
c91223b
fix(overlay): onWillDismiss is called as expected (#12056)
manucorporat Oct 6, 2017
ae4be66
fix(nav): remove bad assert
manucorporat Oct 6, 2017
8ec70ee
chore(dependencies): bump Angular and TypeScript(#13030)
danielsogl Oct 6, 2017
74c5871
refactor(OpaqueToken): change deprecated import (#11916)
danielsogl Oct 6, 2017
ee766e1
doc(defaultHistory): clarify the use of defaultHistory
kensodemann Oct 6, 2017
49e0c37
feat(): better ios11 support
mhartington Oct 9, 2017
9f17b38
chore(dependencies): update lock file
danbucholtz Oct 10, 2017
c4e9b5d
fix(select): overlay types should use shared interface
mlynch Oct 10, 2017
3562408
chore(dependencies): lock file update
danbucholtz Oct 10, 2017
c8be8e2
fix(tabs): emit viewDidEnter and viewDidLeave on app during tab change
mlynch Oct 10, 2017
ecde0ae
Merge pull request #13104 from ionic-team/fix/11694
mlynch Oct 10, 2017
fae5365
refactor(tabs): remove unnecessary console.log
danbucholtz Oct 10, 2017
dc280b4
chore(): clean up the issue template
kensodemann Oct 11, 2017
22747e3
docs(slides): fix typo in code sample (#13091)
Oct 11, 2017
109f029
feat(generator): add --minimal flag
CoreyCole Oct 11, 2017
fd841c5
feat(generator): add --minimal flag
CoreyCole Oct 11, 2017
a050fc7
feat(generator): add --minimal flag
CoreyCole Oct 11, 2017
88db17b
feat(generator): add --minimal flag
CoreyCole Oct 11, 2017
f6c31a6
feat(generator): add --minimal flag
CoreyCole Oct 11, 2017
c8fa963
refactor(generator): remove comma, not consistent
CoreyCole Oct 11, 2017
13065d3
feat(generator): add --minimal flag
CoreyCole Oct 11, 2017
20125f2
feat(generator): add --minimal flag
CoreyCole Oct 11, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
27 changes: 19 additions & 8 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
<!-- Before submitting an issue, please consult our troubleshooting guide (http://ionicframework.com/docs/troubleshooting/) and developer resources (http://ionicframework.com/docs/developer-resources/) -->

<!-- Please make sure you are posting an issue pertaining to the Ionic Framework. If you are having an issue with the Ionic Pro services (Ionic View, Ionic Deploy, etc.) please consult the Ionic Pro support portal (http://support.ionicjs.com) -->

**Ionic version:** (check one with "x")
[ ] **1.x** (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] **2.x**
[ ] **3.x**
[ ] **4.x**

**I'm submitting a ...** (check one with "x")
[ ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

**Current behavior:**
<!-- Describe how the bug manifests. -->
Expand All @@ -15,17 +21,22 @@
<!-- Describe what the behavior would be without the bug. -->

**Steps to reproduce:**
<!-- If you are able to illustrate the bug or feature request with an example, please provide steps to reproduce and if possible a demo using one of the following templates:
<!-- Please explain the steps required to duplicate the issue, especially if you are able to provide a sample application. -->

For Ionic V1 issues - http://plnkr.co/edit/Xo1QyAUx35ny1Xf9ODHx?p=preview
**Related code:**

For Ionic issues - http://plnkr.co/edit/z0DzVL?p=preview
-->
<!-- If you are able to illustrate the bug or feature request with an example, please provide a sample application via one of the following means:

**Related code:**
A sample application via GitHub

StackBlitz (https://stackblitz.com)

Plunker (http://plnkr.co/edit/cpeRJs?p=preview)

-->

```
insert any relevant code here
insert short code snippets here
```

**Other information:**
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ log.txt
*.sublime-workspace

.idea/
.sourcemaps/
.vscode/
.sass-cache/
.versions/
Expand Down
370 changes: 370 additions & 0 deletions CHANGELOG.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
3 changes: 3 additions & 0 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ jobs:
working_directory: ~/ionic/
docker:
- image: node:7
branches:
ignore:
- mono-refactor
steps:
- checkout
- restore_cache:
Expand Down
4 changes: 2 additions & 2 deletions demos/src/alert/pages/page-one/page-one.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ export class PageOne {
buttons: [
{
text: 'Cancel',
handler: (data) => {
handler: () => {
console.log('Cancel clicked');
}
},
{
text: 'Save',
handler: (data) => {
handler: () => {
console.log('Saved clicked');
}
}
Expand Down
2 changes: 1 addition & 1 deletion demos/src/events/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class AppComponent {
this.listenToLoginEvents();
}

openPage(menu: any, page: any) {
openPage(_: any, page: any) {
// find the nav component and set what the root page should be
// reset the nav to remove previous pages and only have this page
// we wouldn't want the back button to show in this scenario
Expand Down
2 changes: 1 addition & 1 deletion demos/src/item-sliding/pages/page-one/page-one.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export class PageOne {
this.expandAction(item, 'downloading', 'Login was downloaded.');
}

expandAction(item: ItemSliding, action: string, text: string) {
expandAction(item: ItemSliding, _: any, text: string) {
// TODO item.setElementClass(action, true);

setTimeout(() => {
Expand Down
2 changes: 1 addition & 1 deletion demos/src/searchbar/pages/page-one/page-one.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class PageOne {

filterItems(ev: any) {
this.setItems();
let val = ev.value;
let val = ev.target.value;

if (val && val.trim() !== '') {
this.items = this.items.filter(function(item) {
Expand Down
14 changes: 14 additions & 0 deletions demos/src/select/pages/page-one/page-one.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
</ion-select>
</ion-item>

<ion-item>
<ion-label>Hair Color</ion-label>
<ion-select [(ngModel)]="hairColor" okText="Okay" cancelText="Dismiss" [compareWith]="compareFn">
<ion-option *ngFor="let o of hairColorData" [value]="o">{{o.text}}</ion-option>
</ion-select>
</ion-item>

<ion-item>
<ion-label>Gaming</ion-label>
<ion-select [(ngModel)]="gaming" okText="Okay" cancelText="Dismiss">
Expand Down Expand Up @@ -147,6 +154,13 @@
</ion-select>
</ion-item>

<ion-item>
<ion-label>Skittles</ion-label>
<ion-select [(ngModel)]="skittles" multiple="true" okText="Okay" cancelText="Dismiss" [compareWith]="compareFn">
<ion-option *ngFor="let o of skittlesData" [value]="o">{{o.text}}</ion-option>
</ion-select>
</ion-item>

<ion-item>
<ion-label>Disabled</ion-label>
<ion-select multiple disabled="true">
Expand Down
32 changes: 32 additions & 0 deletions demos/src/select/pages/page-one/page-one.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ export class PageOne {
petAlertOpts: any;
petData: any;
pets: Array<string>;
hairColorData: any;
hairColor: any;
skittlesData: any;
skittles: Array<any>;
notifications: string = 'mute_1';
rating: number = 2;

Expand All @@ -31,9 +35,37 @@ export class PageOne {
{ text: 'Honey Badger', value: 'honeybadger' },
];

this.hairColorData = [
{ text: 'Brown', value: 'brown' },
{ text: 'Blonde', value: 'blonde' },
{ text: 'Black', value: 'black' },
{ text: 'Red', value: 'red' }
];

// Pre-selected object with different object reference
this.hairColor = { text: 'Brown', value: 'brown' };

this.skittlesData = [
{ text: 'Red', value: 'red' },
{ text: 'Orange', value: 'orange' },
{ text: 'Yellow', value: 'yellow' },
{ text: 'Green', value: 'green' },
{ text: 'Purple', value: 'purple' }
];

// Pre-selected object with different object reference
this.skittles = [
{ text: 'Red', value: 'red' },
{ text: 'Purple', value: 'purple' }
];

this.pets = ['cat', 'dog'];
}

compareFn(option1: any, option2: any) {
return option1.value === option2.value;
}

monthChange(val: any) {
console.log('Month Change:', val);
}
Expand Down
Loading