Skip to content

fix(datetime): use spread operator to copy pickerOptions #13202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manucorporat merged 2 commits into from
Oct 27, 2017
Merged

fix(datetime): use spread operator to copy pickerOptions #13202

manucorporat merged 2 commits into from
Oct 27, 2017

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Oct 20, 2017

Short description of what this resolves:

Passing buttons in pickerOptions to the DateTime component will drop the handler functions because of the deepCopy.

Changes proposed in this pull request:

  • Uses the spread operator instead of the deepCopy function.
  • Adds pickerOptions to one of the examples in the e2e test

Ionic Version: 3.x

Fixes: #11641

@brandyscarney brandyscarney mentioned this pull request Oct 20, 2017
Closed
@mhartington mhartington added this to the 3.9.0 milestone Oct 26, 2017
@kensodemann kensodemann self-requested a review October 27, 2017 15:08
@manucorporat manucorporat merged commit 2ab8385 into master Oct 27, 2017
@brandyscarney brandyscarney deleted the datetime-options-fix branch October 30, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kensodemann kensodemann Awaiting requested review from kensodemann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@brandyscarney @manucorporat @mhartington