Skip to content

fix(ng-add): Fix path for css styles in monorepo #19904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2020
Merged

fix(ng-add): Fix path for css styles in monorepo #19904

merged 4 commits into from
Jan 23, 2020

Conversation

eduardoRoth
Copy link
Contributor

@eduardoRoth eduardoRoth commented Nov 13, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): ng add schema updated to handle multiple applications project structure

What is the current behavior?

When you run ng add @ionic/angular --project=name, the variables.css file is created but it's path in angular.json is wrong, so you need to update it manually

Issue Number: N/A

What is the new behavior?

Added a new option to the schema:

ng add @ionic/angular --project=my-project --root=apps

It'll update the angular.json file to point the variables.css file to apps/my-project/src/theme/variables.css

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: angular @ionic/angular package label Nov 13, 2019
@eduardoRoth eduardoRoth changed the title feat(ng-add): Fix path for css styles in monorepo fix(ng-add): Fix path for css styles in monorepo Nov 13, 2019
@eduardoRoth
Copy link
Contributor Author

@mhartington @SchnWalter just updated the code with your suggestions.

Copy link
Contributor

@mhartington mhartington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants