feat(textarea): add workaround for dynamic slot content #27661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
changed the title
liamdebeasi
requested review from
a team and
averyjohnston
and removed request for
a team
averyjohnston
suggested changes
Jun 16, 2023
There was a problem hiding this comment.
Looks like the branch might need a rebase? I'm guessing these screenshots shouldn't be in here.
liamdebeasi
force-pushed
the
4409-dynamic
branch
from
c7c1384 to
4eb41af
Compare
|
Grabbed latest changes from feature-7.1, so both issues should be resolved. |
averyjohnston
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Slotted content added async does not cause the component to re-render.
What is the new behavior?
Does this introduce a breaking change?
Other information