-
Notifications
You must be signed in to change notification settings - Fork 13.5k
test(item-sliding): re-enable flaky tests #28192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9319815
test(item-sliding): re-enable flaky tests
thetaPC 650e9d6
chore(): add updated snapshots
Ionitron f237597
test(item-sliding): re-enable scroll-target
thetaPC 0b63b1f
test(item-sliding): switched to ticket
thetaPC adf9753
test(item-sliding): update todo note
thetaPC b3e5e3d
test(item-sliding): requested changes
thetaPC aed14c3
test(item-sliding): remove only
thetaPC 974298a
test(item-sliding): move kebab lower
thetaPC 52cb7db
test(item-sliding): update comment
thetaPC 0c7c23c
Merge branch 'main' of github.com:ionic-team/ionic-framework into FW-…
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 42 additions & 7 deletions
49
core/src/components/item-sliding/test/basic/item-sliding.e2e.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-11.7 KB
(30%)
.../item-sliding.e2e.ts-snapshots/item-sliding-end-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-173 Bytes
(97%)
...item-sliding.e2e.ts-snapshots/item-sliding-end-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12 KB
(28%)
.../item-sliding.e2e.ts-snapshots/item-sliding-end-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-10.6 KB
(32%)
.../item-sliding.e2e.ts-snapshots/item-sliding-end-ios-rtl-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.21 KB
...item-sliding.e2e.ts-snapshots/item-sliding-end-ios-rtl-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.56 KB
.../item-sliding.e2e.ts-snapshots/item-sliding-end-ios-rtl-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.77 KB
(35%)
...c/item-sliding.e2e.ts-snapshots/item-sliding-end-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.88 KB
(33%)
...c/item-sliding.e2e.ts-snapshots/item-sliding-end-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.02 KB
(35%)
...c/item-sliding.e2e.ts-snapshots/item-sliding-end-md-rtl-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.54 KB
.../item-sliding.e2e.ts-snapshots/item-sliding-end-md-rtl-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.07 KB
...c/item-sliding.e2e.ts-snapshots/item-sliding-end-md-rtl-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12.4 KB
(35%)
...tem-sliding.e2e.ts-snapshots/item-sliding-start-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+633 Bytes
(110%)
...em-sliding.e2e.ts-snapshots/item-sliding-start-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12.8 KB
(33%)
...tem-sliding.e2e.ts-snapshots/item-sliding-start-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12.7 KB
(35%)
...tem-sliding.e2e.ts-snapshots/item-sliding-start-ios-rtl-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.15 KB
...em-sliding.e2e.ts-snapshots/item-sliding-start-ios-rtl-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.46 KB
...tem-sliding.e2e.ts-snapshots/item-sliding-start-ios-rtl-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12.8 KB
(33%)
...item-sliding.e2e.ts-snapshots/item-sliding-start-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12.8 KB
(31%)
...item-sliding.e2e.ts-snapshots/item-sliding-start-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-13 KB
(34%)
...item-sliding.e2e.ts-snapshots/item-sliding-start-md-rtl-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+7.64 KB
...tem-sliding.e2e.ts-snapshots/item-sliding-start-md-rtl-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.88 KB
...item-sliding.e2e.ts-snapshots/item-sliding-start-md-rtl-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
31 changes: 23 additions & 8 deletions
31
core/src/components/item-sliding/test/icons/item-sliding.e2e.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+2.89 KB
...iding.e2e.ts-snapshots/item-sliding-iconsBottom-ios-ltr-Mobile-Chrome-linux.png
brandyscarney marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.69 KB
...ding.e2e.ts-snapshots/item-sliding-iconsBottom-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.77 KB
...iding.e2e.ts-snapshots/item-sliding-iconsBottom-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.79 KB
...iding.e2e.ts-snapshots/item-sliding-iconsBottom-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.57 KB
...ding.e2e.ts-snapshots/item-sliding-iconsBottom-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.62 KB
...iding.e2e.ts-snapshots/item-sliding-iconsBottom-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.77 KB
...liding.e2e.ts-snapshots/item-sliding-iconsBottom-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.68 KB
...iding.e2e.ts-snapshots/item-sliding-iconsBottom-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.65 KB
...liding.e2e.ts-snapshots/item-sliding-iconsBottom-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.73 KB
...liding.e2e.ts-snapshots/item-sliding-iconsBottom-md-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.61 KB
...iding.e2e.ts-snapshots/item-sliding-iconsBottom-md-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.59 KB
...liding.e2e.ts-snapshots/item-sliding-iconsBottom-md-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.2 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-ios-ltr-Mobile-Chrome-linux.png
brandyscarney marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Binary file added
BIN
+3.03 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsEnd-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.1 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.23 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.94 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsEnd-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.11 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.16 KB
...m-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.19 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.18 KB
...m-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.18 KB
...m-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-md-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.22 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-md-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.2 KB
...m-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-md-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.74 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsOnly-ios-ltr-Mobile-Chrome-linux.png
brandyscarney marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Binary file added
BIN
+2.38 KB
...liding.e2e.ts-snapshots/item-sliding-iconsOnly-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.55 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsOnly-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.76 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsOnly-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.36 KB
...liding.e2e.ts-snapshots/item-sliding-iconsOnly-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.56 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsOnly-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.64 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsOnly-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.21 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsOnly-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.44 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsOnly-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.65 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsOnly-md-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.21 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsOnly-md-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.46 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsOnly-md-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.21 KB
...liding.e2e.ts-snapshots/item-sliding-iconsStart-ios-ltr-Mobile-Chrome-linux.png
brandyscarney marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Binary file added
BIN
+3.04 KB
...iding.e2e.ts-snapshots/item-sliding-iconsStart-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.11 KB
...liding.e2e.ts-snapshots/item-sliding-iconsStart-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.22 KB
...liding.e2e.ts-snapshots/item-sliding-iconsStart-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.96 KB
...iding.e2e.ts-snapshots/item-sliding-iconsStart-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.1 KB
...liding.e2e.ts-snapshots/item-sliding-iconsStart-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.17 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsStart-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.21 KB
...liding.e2e.ts-snapshots/item-sliding-iconsStart-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.18 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsStart-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.16 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsStart-md-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.19 KB
...liding.e2e.ts-snapshots/item-sliding-iconsStart-md-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.19 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsStart-md-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.2 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsTop-ios-ltr-Mobile-Chrome-linux.png
brandyscarney marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Binary file added
BIN
+3 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsTop-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.09 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsTop-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.22 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsTop-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.96 KB
...sliding.e2e.ts-snapshots/item-sliding-iconsTop-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.1 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsTop-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.18 KB
...m-sliding.e2e.ts-snapshots/item-sliding-iconsTop-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.12 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsTop-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.17 KB
...m-sliding.e2e.ts-snapshots/item-sliding-iconsTop-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.2 KB
...m-sliding.e2e.ts-snapshots/item-sliding-iconsTop-md-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.13 KB
...-sliding.e2e.ts-snapshots/item-sliding-iconsTop-md-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.21 KB
...m-sliding.e2e.ts-snapshots/item-sliding-iconsTop-md-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.