test(docs): update viewport docs #28197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed this constant but realized the docs were outdated
liamdebeasi
changed the title
liamdebeasi
requested review from
a team and
mapsandapps
and removed request for
a team
mapsandapps
approved these changes
Sep 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
liamdebeasi
added a commit
that referenced
this pull request
Sep 22, 2023
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> I needed this constant for a different PR but realized the docs were outdated: https://github.com/ionic-team/ionic-framework/blob/81714d45bd97f0ba91729959b60a0dc1d1d06533/core/src/utils/test/playwright/viewports/index.ts ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Docs reference correct constant name ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
liamdebeasi
added a commit
that referenced
this pull request
Sep 26, 2023
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> I needed this constant for a different PR but realized the docs were outdated: https://github.com/ionic-team/ionic-framework/blob/81714d45bd97f0ba91729959b60a0dc1d1d06533/core/src/utils/test/playwright/viewports/index.ts ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Docs reference correct constant name ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
I needed this constant for a different PR but realized the docs were outdated: https://github.com/ionic-team/ionic-framework/blob/81714d45bd97f0ba91729959b60a0dc1d1d06533/core/src/utils/test/playwright/viewports/index.ts
What is the new behavior?
Does this introduce a breaking change?
Other information