Skip to content

refactor(theming): remove Sass default flags #29199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

brandyscarney
Copy link
Member

Issue number: N/A

What is the current behavior?

Currently, every Sass variable in Ionic has the !default flag added to the end.

From the Sass variables documentation:

Normally when you assign a value to a variable, if that variable already had a value, its old value is overwritten. But if you’re writing a Sass library, you might want to allow your users to configure your library’s variables before you use them to generate CSS.

To make this possible, Sass provides the !default flag. This assigns a value to a variable only if that variable isn’t defined or its value is null. Otherwise, the existing value will be used.

In past versions of Ionic Framework, developers wrote Sass variables to rebuild Ionic Framework using their own values. In the latest versions of Ionic Framework, this is not possible.

What is the new behavior?

Removes the !default flag from all Sass variables.

Does this introduce a breaking change?

  • Yes
  • No

@github-actions github-actions bot added the package: core @ionic/core package label Mar 21, 2024
@brandyscarney
Copy link
Member Author

Closing due to conflicts. We are going to update main first here: #29401 and then pull the changes into the next branch.

@brandyscarney brandyscarney deleted the bc/remove-sass-default branch April 25, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants