fix(modal): remove enable scrolling delay with sheet modal #29259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Part of #24583
What is the current behavior?
There is a noticeable delay between when users finish swiping and when scrolling is re-enabled. This is because the animation takes ~500ms to complete when finishing the swipe.
This does not align with how we re-enable scrolling in the card modal. In the card modal, scrolling is re-enabled as soon as the gesture is released.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
7.8.3-dev.11712114476.152fc43d
Reviewers:
Please test this on a physical iOS and Android devices. Ensure that swiping the modal fully open does a) re-enable scrolling and b) re-enable scrolling without a 500ms delay.
Card Behavior
card-scroll-enable.mov
Sheet Behavior
main
sheet-scroll-enable-bad.mov
sheet-scroll-enable-good.mov