Skip to content

fix(modal): remove enable scrolling delay with sheet modal #29259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 3, 2024

Issue number: Part of #24583


What is the current behavior?

There is a noticeable delay between when users finish swiping and when scrolling is re-enabled. This is because the animation takes ~500ms to complete when finishing the swipe.

This does not align with how we re-enable scrolling in the card modal. In the card modal, scrolling is re-enabled as soon as the gesture is released.

What is the new behavior?

  • To fix this, I aligned the behavior of the sheet modal with that of the card modal. As a result, whether or not the content is scrollable is now tied to the state of the gesture rather than the state of the animation.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 7.8.3-dev.11712114476.152fc43d

Reviewers:

Please test this on a physical iOS and Android devices. Ensure that swiping the modal fully open does a) re-enable scrolling and b) re-enable scrolling without a 500ms delay.

Card Behavior

Demo
card-scroll-enable.mov

Sheet Behavior

main branch
sheet-scroll-enable-bad.mov
sheet-scroll-enable-good.mov

@github-actions github-actions bot added the package: core @ionic/core package label Apr 3, 2024
@liamdebeasi liamdebeasi marked this pull request as ready for review April 3, 2024 03:50
@liamdebeasi liamdebeasi requested a review from a team as a code owner April 3, 2024 03:50
@liamdebeasi liamdebeasi requested review from averyjohnston and removed request for a team April 3, 2024 03:50
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a physical iPhone and on an emulated Pixel 5, behavior looks good 👍

@liamdebeasi liamdebeasi merged commit d7ec370 into FW-621 Apr 9, 2024
@liamdebeasi liamdebeasi deleted the 621-a branch April 9, 2024 20:37
github-merge-queue bot pushed a commit that referenced this pull request Apr 10, 2024
Issue number: resolves #24583

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

See
#24583 (comment)

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- See #29260 and
#29259. This PR is a
combination of previously reviewed fixes.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->


Dev build: `7.8.3-dev.11712695191.1d7ec370`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants