Skip to content

chore(deps): update stencil core #30132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: feature-8.6
Choose a base branch
from
Open

chore(deps): update stencil core #30132

wants to merge 13 commits into from

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jan 13, 2025 •
edited by brandyscarney
Loading

We have shipped various of improvements to the Stencil project and runtime. You can take a close look at our changelog but since v4.20.0 we mainly shipped improvements on the following issues:

Major Improvements:

  • Enhanced Shadow DOM and hydration support
    • Improved client-side hydration for SSR
    • Better handling of shadow root styles and component hydration
    • More reliable serialization of Shadow DOM components

Key Bug Fixes:

  • Resolved performance issues due to detached nodes in memory
  • Fixed several critical issues with scoped slots and component styling
  • Improved handling of SVG class attributes and template tags
  • Enhanced runtime decorator functionality
  • Better handling of form-associated callbacks

Technical Updates:

  • Updated to TypeScript 5.5
  • Added support for customizable Mermaid diagram colors in documentation

I don't see any critical changes that may impact Ionic users and feel confident we can ship this.

Dev Build

8.5.4-dev.11744646756.1244bf71

@christian-bromann christian-bromann requested a review from a team as a code owner January 13, 2025 19:48
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 4:06pm

@github-actions github-actions bot added the package: core @ionic/core package label Jan 13, 2025
@Sagie501
Copy link

Does this will solve the following issue?
#30084

@christian-bromann
Copy link
Member Author

Does this will solve the following issue?

Definitely worth verifying this! I created a dev build 8.4.2-dev.11736797843.16cc5058 which we currently use to test.

@Sagie501
Copy link

Does this will solve the following issue?

Definitely worth verifying this! I created a dev build 8.4.2-dev.11736797843.16cc5058 which we currently use to test.

I tried it now it the issue still exist 😔

@capc0
Copy link
Contributor

capc0 commented Jan 17, 2025

related issue #30136

@brandyscarney brandyscarney changed the title chore(core): update stencil core chore(deps): update stencil core Jan 17, 2025
@capc0
Copy link
Contributor

capc0 commented Jan 23, 2025

I have tested the dev build (8.4.2-dev.11736797843.16cc5058) with updated stencil a bit and found a 2 issues in the console when clicking through our app:

image image
image image

@a7medm7med
Copy link

a7medm7med commented Feb 15, 2025 •
edited
Loading

@christian-bromann I'm encountering the same errors with Stencil 4.26.0, and they only occur when using React.

Screenshot 2025-02-15 173628

@a7medm7med
Copy link

@christian-bromann The same type of error also occurs in Vue (I haven't tested it in Angular yet).

Screenshot 2025-02-17 190515

@ralphcode ralphcode mentioned this pull request Feb 25, 2025
Open
3 tasks
@ralphcode
Copy link

ralphcode commented Mar 13, 2025 •
edited
Loading

Fyi, I've tested this locally and upgrading to 4.27.2 it does not appear to fix #30215 (in Angular)

@christian-bromann do you by any chance know if this is a bug in Ionic or should be replicated in Stencil to be fixed there? Thanks

@ralphcode ralphcode mentioned this pull request Mar 23, 2025
Closed
3 tasks
@christian-bromann christian-bromann mentioned this pull request Apr 4, 2025
Open
3 tasks
@github-actions github-actions bot added the package: angular @ionic/angular package label Apr 9, 2025
@brandyscarney brandyscarney changed the base branch from main to feature-8.6 April 9, 2025 14:48
@thetaPC thetaPC mentioned this pull request Apr 11, 2025
Open
3 tasks
brandyscarney
brandyscarney approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the dev build out in an Ionic JavaScript project using Vite, the Ionic Angular conference app, Ionic React conference app, and Ionic Vue conference app. I could not find any issues in my testing. Great work on this! 🎉

thetaPC
thetaPC approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with Ionic docs StackBlitz playgrounds and the framework test pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@thetaPC thetaPC thetaPC approved these changes

@gnbm gnbm Awaiting requested review from gnbm gnbm is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@christian-bromann @Sagie501 @capc0 @a7medm7med @ralphcode @brandyscarney @thetaPC