[ionicHistory] add method to remove the back view#3811
Merged
danbucholtz merged 2 commits intoionic-team:masterfrom Apr 15, 2016
Merged
[ionicHistory] add method to remove the back view#3811danbucholtz merged 2 commits intoionic-team:masterfrom
danbucholtz merged 2 commits intoionic-team:masterfrom
Conversation
|
+1 |
1 similar comment
|
+1 |
|
Any progress in this PR? It would be great to include in the next version! |
|
+1 |
|
+1 |
Contributor
|
Hi @ashconnell, can you write some unit tests for this? We can't merge this without tests. Thank you for the contribution, this is great! Thanks, |
Contributor
|
I wrote a test and merged due to demand. Thank you for your contribution! We appreciate it! Thanks, |
|
If I use the ui-router location replace, it doesn't work but using angular location replace does work: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves issue #3750
Adds a method
$ionicHistory.removeBackView()which removes the cached view, element, scope, and rejigs the history. I'm already using this in production in various use-cases.This predominantly solves the issue where in most angular applications you can use
$state.go('app.foo', { location: 'replace' })except in ionic, the history is managed manually - this is the solution.Would be good to have it part of the core!
I'm working on the method
$ionicHistory.removeFromHistory(stateName/id)which we also need for our app - and the ionic community would also benefit from this going forward. Keep an eye out.